Ticket #13402: 0001-Fix-crash-with-missing-midi_settings.patch

src/preferences/media/MidiSettingsView.cpp

@@ -200 +200 @@
 {
     struct BPrivate::midi_settings settings;
     if (BPrivate::read_midi_settings(&settings) == B_OK)
-        fActiveSoundFont = new BString(settings.soundfont_file);
+        fActiveSoundFont.SetTo(settings.soundfont_file);
 }
 
 
 void
 MidiSettingsView::_SaveSettings()
 {
-    fActiveSoundFont = new BString(_SelectedSoundFont());
-    if (fActiveSoundFont->Length() > 0) {
+    fActiveSoundFont = _SelectedSoundFont();
+    if (fActiveSoundFont.Length() > 0) {
         struct BPrivate::midi_settings settings;
-        strlcpy(settings.soundfont_file, fActiveSoundFont->String(),
+        strlcpy(settings.soundfont_file, fActiveSoundFont.String(),
             sizeof(settings.soundfont_file));
         BPrivate::write_midi_settings(settings);
     }
@@ -228 +228 @@
     }
     for (int32 i = 0; i < fListView->CountItems(); i++) {
         BStringItem* item = (BStringItem*)fListView->ItemAt(i);
-        if (!strcmp(item->Text(), fActiveSoundFont->String())) {
+        if (!strcmp(item->Text(), fActiveSoundFont.String())) {
             fListView->Select(i);
             break;
         }

src/preferences/media/MidiSettingsView.h

@@ -9 +9 @@
 
 #include "MediaViews.h"
 
+#include "String.h"
+
 class BButton;
 class BListView;
-class BString;
 class BStringView;
 
 class MidiSettingsView : public SettingsView {
@@ -32 +33 @@
     void            _UpdateSoundFontStatus();
 
     BListView*      fListView;
-    BString*        fActiveSoundFont;
+    BString         fActiveSoundFont;
     BStringView*    fSoundFontStatus;
 };