Ticket #13757: 0001-Recalculate-BListView-cached-selection-boxes-in-Inva.patch

docs/user/interface/ListView.dox

@@ -827 +827 @@
 
 
 /*!
+    \fn void BListView::Invalidate()
+    \brief Updates cached item selection coordinates and sends a message
+           to App Server to redraw the view.
+
+    The coordinates of BListItems are cached and used for drawing selection
+    highlights and detecting mouse clicks.  If you change the size of a
+    BListItem with BListItem::SetHeight(), it could make the following
+    BListItems highlight incorrectly; calling this will recalculate the
+    selection coordinates for all BListItems and then do a
+    BView::Invalidate().
+
+    \remark Adding or removing a BListItem does automatically update the
+            selection coordinates and redraws following items.  No need to
+            call Invalidate().
+
+    \note Since BView::Invalidate() is not a virtual function, you can't
+          access this Invalidate() through a generic BView pointer.  Maybe
+          we should make _RecalcItemTops() a public function rather than
+          hiding the cache from the user?
+
+    \since Haiku R1
+*/
+
+
+/*!
     \fn void BListView::InvalidateItem(int32 index)
     \brief Draws the list item at the specified \a index.
 

headers/os/interface/ListView.h

@@ -109 +109 @@
             void                DoForEach(bool (*func)(BListItem* item,
                                     void* arg), void* arg);
             const BListItem**   Items() const;
+
+            // Since Invalidate() isn't virtual, the other BView varieties
+            // would get masked by our redeclaration, so have to redeclare
+            // all of them here too.
+            void                Invalidate();
+            void                Invalidate(BRect invalRect);
+            void                Invalidate(const BRegion* invalRegion);
             void                InvalidateItem(int32 index);
+
             void                ScrollToSelection();
 
             void                Select(int32 index, bool extend = false);

src/kits/interface/ListView.cpp

@@ -1085 +1085 @@
 
 
 void
+BListView::Invalidate()
+{
+    _RecalcItemTops(0);
+    BView::Invalidate();
+}
+
+
+void
+BListView::Invalidate(BRect invalRect)
+{
+    BView::Invalidate(invalRect);
+}
+
+
+void
+BListView::Invalidate(const BRegion* invalRegion)
+{
+    BView::Invalidate(invalRegion);
+}
+
+
+void
 BListView::InvalidateItem(int32 index)
 {
     Invalidate(ItemFrame(index));