Ticket #15170: ProcessController-cppcheck.txt

File ProcessController-cppcheck.txt, 5.9 KB (added by Coldfirex, 3 years ago)
Line 
1haiku\src\apps\processcontroller\AutoIcon.h,16,style,noExplicitConstructor,Class 'AutoIcon' has a constructor with 1 argument that is not explicit.
2haiku\src\apps\processcontroller\AutoIcon.h,24,style,noExplicitConstructor,Class 'AutoIcon' has a constructor with 1 argument that is not explicit.
3haiku\src\apps\processcontroller\KernelMemoryBarMenuItem.cpp,28,performance,useInitializationList,Variable 'fPhysicalMemory' is assigned in constructor body. Consider performing initialization in initialization list.
4haiku\src\apps\processcontroller\KernelMemoryBarMenuItem.cpp,29,performance,useInitializationList,Variable 'fCommittedMemory' is assigned in constructor body. Consider performing initialization in initialization list.
5haiku\src\apps\processcontroller\KernelMemoryBarMenuItem.cpp,30,performance,useInitializationList,Variable 'fCachedMemory' is assigned in constructor body. Consider performing initialization in initialization list.
6haiku\src\apps\processcontroller\KernelMemoryBarMenuItem.h,14,style,noExplicitConstructor,Class 'KernelMemoryBarMenuItem' has a constructor with 1 argument that is not explicit.
7haiku\src\apps\processcontroller\ProcessController.h,21,style,noExplicitConstructor,Class 'ProcessController' has a constructor with 1 argument that is not explicit.
8haiku\src\apps\processcontroller\ProcessController.h,22,style,noExplicitConstructor,Class 'ProcessController' has a constructor with 1 argument that is not explicit.
9haiku\src\apps\processcontroller\MemoryBarMenu.cpp,93,error,memleakOnRealloc,Common realloc mistake: 'fRecycleList' nulled but not freed upon failure
10haiku\src\apps\processcontroller\MemoryBarMenu.cpp,131,error,memleakOnRealloc,Common realloc mistake: 'fTeamList' nulled but not freed upon failure
11haiku\src\apps\processcontroller\MemoryBarMenu.cpp,88,style,cstyleCast,C-style pointer casting
12haiku\src\apps\processcontroller\MemoryBarMenu.cpp,172,style,cstyleCast,C-style pointer casting
13haiku\src\apps\processcontroller\MemoryBarMenu.cpp,87,style,unreadVariable,Variable 'total' is assigned a value that is never used.
14haiku\src\apps\processcontroller\MemoryBarMenu.cpp,104,style,unreadVariable,Variable 'total' is assigned a value that is never used.
15haiku\src\apps\processcontroller\MemoryBarMenu.cpp,151,style,unreadVariable,Variable 'total' is assigned a value that is never used.
16haiku\src\apps\processcontroller\Preferences.h,15,style,noExplicitConstructor,Class 'Preferences' has a constructor with 1 argument that is not explicit.
17haiku\src\apps\processcontroller\Preferences.h,16,style,noExplicitConstructor,Class 'Preferences' has a constructor with 1 argument that is not explicit.
18haiku\src\apps\processcontroller\PCWorld.cpp,82,style,shadowVariable,Local variable 'deskbar' shadows outer variable
19haiku\src\apps\processcontroller\Preferences.cpp,33,style,strdupCalled,Obsolete function 'strdup' called. It is recommended to use '_strdup' instead.
20haiku\src\apps\processcontroller\Preferences.cpp,35,style,strdupCalled,Obsolete function 'strdup' called. It is recommended to use '_strdup' instead.
21haiku\src\apps\processcontroller\Preferences.cpp,62,style,strdupCalled,Obsolete function 'strdup' called. It is recommended to use '_strdup' instead.
22haiku\src\apps\processcontroller\PriorityMenu.cpp,63,style,variableScope,The scope of the variable 'item' can be reduced.
23haiku\src\apps\processcontroller\PriorityMenu.cpp,64,style,variableScope,The scope of the variable 'message' can be reduced.
24haiku\src\apps\processcontroller\QuitMenu.cpp,59,style,cstyleCast,C-style pointer casting
25haiku\src\apps\processcontroller\QuitMenu.cpp,90,style,cstyleCast,C-style pointer casting
26haiku\src\apps\processcontroller\QuitMenu.cpp,139,style,cstyleCast,C-style pointer casting
27haiku\src\apps\processcontroller\TeamBarMenuItem.cpp,266,style,cstyleCast,C-style pointer casting
28haiku\src\apps\processcontroller\TeamBarMenu.cpp,81,error,memleakOnRealloc,Common realloc mistake: 'fRecycleList' nulled but not freed upon failure
29haiku\src\apps\processcontroller\TeamBarMenu.cpp,115,error,memleakOnRealloc,Common realloc mistake: 'fTeamList' nulled but not freed upon failure
30haiku\src\apps\processcontroller\TeamBarMenu.cpp,76,style,cstyleCast,C-style pointer casting
31haiku\src\apps\processcontroller\TeamBarMenu.cpp,160,style,cstyleCast,C-style pointer casting
32haiku\src\apps\processcontroller\ThreadBarMenu.cpp,98,error,memleakOnRealloc,Common realloc mistake: 'fThreadsRec' nulled but not freed upon failure
33haiku\src\apps\processcontroller\ThreadBarMenu.cpp,127,style,cstyleCast,C-style pointer casting
34haiku\src\apps\processcontroller\ProcessController.cpp,153,warning,uninitMemberVar,Member variable 'ProcessController::fMemoryUsage' is not initialized in the constructor.
35haiku\src\apps\processcontroller\ProcessController.cpp,178,warning,uninitMemberVar,Member variable 'ProcessController::fMemoryUsage' is not initialized in the constructor.
36haiku\src\apps\processcontroller\ProcessController.cpp,195,warning,uninitMemberVar,Member variable 'ProcessController::fMemoryUsage' is not initialized in the constructor.
37haiku\src\apps\processcontroller\ProcessController.cpp,641,style,duplicateCondition,The if condition is the same as the previous if condition
38haiku\src\apps\processcontroller\ProcessController.cpp,521,style,knownConditionTrueFalse,Condition '!set' is always true
39haiku\src\apps\processcontroller\ProcessController.cpp,816,style,shadowVariable,Local variable 'item' shadows outer variable
40haiku\src\apps\processcontroller\ProcessController.cpp,831,style,shadowVariable,Local variable 'm' shadows outer variable
41haiku\src\apps\processcontroller\ThreadBarMenuItem.cpp,16,warning,uninitMemberVar,Member variable 'ThreadBarMenuItem::fUser' is not initialized in the constructor.
42haiku\src\apps\processcontroller\ThreadBarMenuItem.cpp,137,style,cstyleCast,C-style pointer casting
43haiku\src\apps\processcontroller\ThreadBarMenuItem.cpp,161,style,cstyleCast,C-style pointer casting