Ticket #6349: gcc-warnings-fix.patch

File gcc-warnings-fix.patch, 11.3 KB (added by kaliber, 14 years ago)

Fixes after code review on mailing list

  • src/apps/soundrecorder/TrackSlider.cpp

     
    7575   
    7676    fBitmap = new BBitmap(rect, BScreen().ColorSpace(), true);
    7777   
    78     fBitmapView = new SliderOffscreenView(rect.OffsetToSelf(B_ORIGIN), (char *)"bitmapView");
     78    fBitmapView = new SliderOffscreenView(rect.OffsetToSelf(B_ORIGIN), "bitmapView");
    7979    fBitmap->AddChild(fBitmapView);
    8080   
    8181    fBitmapView->fRight = Bounds().right - kLeftRightTrackSliderWidth;
    … …  
    477477}
    478478
    479479
    480 SliderOffscreenView::SliderOffscreenView(BRect frame, char *name)
     480SliderOffscreenView::SliderOffscreenView(BRect frame, const char *name)
    481481    : BView(frame, name, B_FOLLOW_LEFT | B_FOLLOW_TOP, B_WILL_DRAW),
    482482    leftBitmap(BRect(BPoint(0,0), kLeftRightTrackSliderSize), B_CMAP8),
    483483    rightBitmap(BRect(BPoint(0,0), kLeftRightTrackSliderSize), B_CMAP8),

  • src/apps/soundrecorder/TrackSlider.h

     
    1414class SliderOffscreenView : public BView {
    1515
    1616public:
    17     SliderOffscreenView(BRect frame, char *name);
     17    SliderOffscreenView(BRect frame, const char *name);
    1818    virtual     ~SliderOffscreenView();
    1919    virtual void    DrawX();
    2020   

  • src/add-ons/media/media-add-ons/firewire_dv/FireWireCard.cpp

     
    7575    {203, 2997},    /* = (8000 - 29.97 * 250)/(29.97 * 250) */
    7676    {1, 15},    /* = (8000 - 25 * 300)/(25 * 300) */
    7777};
    78 char *system_name[] = {(char *)"NTSC", (char *)"PAL"};
     78const char *system_name[] = {"NTSC", "PAL"};
    7979int frame_rate[] = {30, 25};
    8080
    8181#define DV_PSIZE 512

  • src/add-ons/media/media-add-ons/opensound/OpenSoundAddOn.cpp

     
    6464    fInitCheckStatus = B_NO_INIT;
    6565
    6666    /* unix paths */
    67     if (RecursiveScan((char *)"/dev/oss/") != B_OK)
     67    if (RecursiveScan("/dev/oss/") != B_OK)
    6868        return;
    6969    /*
    7070    if (RecursiveScan("/dev/audio/oss/") != B_OK)
    … …  
    193193}
    194194
    195195status_t
    196 OpenSoundAddOn::RecursiveScan(char* rootPath, BEntry *rootEntry)
     196OpenSoundAddOn::RecursiveScan(const char* rootPath, BEntry *rootEntry)
    197197{
    198198    status_t err;
    199199    int mixer;

  • src/add-ons/media/media-add-ons/opensound/OpenSoundNode.cpp

     
    485485            mediaInput.destination.port = ControlPort();
    486486            mediaInput.destination.id = fInputs.CountItems();
    487487            mediaInput.node = Node();
    488             char *prefix = (char *)"";
     488            const char *prefix = "";
    489489            if (strstr(engine->Info()->name, "SPDIF"))
    490                 prefix = (char *)"S/PDIF ";
     490                prefix = "S/PDIF ";
    491491            sprintf(mediaInput.name, "%sOutput %ld (%s)", prefix,
    492492                mediaInput.destination.id, gSupportedFormatsNames[f]);
    493493
    … …  
    533533            mediaOutput.source.port = ControlPort();
    534534            mediaOutput.source.id = fOutputs.CountItems();
    535535            mediaOutput.node = Node();
    536             char *prefix = (char *)"";
     536            const char *prefix = "";
    537537            if (strstr(engine->Info()->name, "SPDIF"))
    538                 prefix = (char *)"S/PDIF ";
     538                prefix = "S/PDIF ";
    539539            sprintf(mediaOutput.name, "%sInput %ld (%s)", prefix,
    540540                mediaOutput.source.id, gSupportedFormatsNames[f]);
    541541

  • src/add-ons/media/media-add-ons/opensound/OpenSoundAddOn.h

     
    5353        /************************/
    5454
    5555    private:
    56         status_t RecursiveScan(char* path, BEntry *rootEntry = NULL);
     56        status_t RecursiveScan(const char* path, BEntry *rootEntry = NULL);
    5757        void SaveSettings(void);
    5858        void LoadSettings(void);
    5959       

  • src/add-ons/kernel/bus_managers/firewire/firewire.c

     
    10961096fw_tl2xfer(struct firewire_comm *fc, int node, int tlabel, int tcode)
    10971097{
    10981098    struct fw_xfer *xfer;
     1099    int s;
    10991100    int req;
    11001101
     1102    s = splfw();
     1103
    11011104    mtx_lock(&fc->tlabel_lock);
    11021105    STAILQ_FOREACH(xfer, &fc->tlabels[tlabel], tlabel)
    11031106        if(xfer->send.hdr.mode.hdr.dst == node) {

  • src/add-ons/kernel/drivers/graphics/common/log_dump.c

     
    1919system_info sysinfo;
    2020
    2121// dump one entry
    22 void log_printentry( FILE *logfile, log_entry *entry )
     22static void log_printentry( FILE *logfile, log_entry *entry )
    2323{
    2424    uint64 time;
    2525    uint32 min, sec, mill, mic;

  • src/add-ons/kernel/drivers/graphics/common/log_dump.h

     
    1313#include <SupportDefs.h>
    1414
    1515void log_printall( FILE *logfile, char *buffer, uint32 buffer_len );
    16 void log_printentry( FILE *logfile, log_entry *entry );
    1716
    1817#endif

  • src/add-ons/accelerants/3dfx/accelerant.h

     
    185185// Write a value to an 32-bit reg using a mask.  The mask selects the
    186186// bits to be modified.
    187187#define OUTREGM(addr, value, mask)  \
    188     (OUTREG(addr, (INREG(addr) & ~mask) | (value & mask)))
     188    (OUTREG(addr, (INREG(addr) & ~(mask)) | ((value) & (mask))))
    189189
    190190
    191191#endif  // _ACCELERANT_H

  • src/add-ons/accelerants/ati/accelerant.h

     
    202202// Write a value to an 32-bit reg using a mask.  The mask selects the
    203203// bits to be modified.
    204204#define OUTREGM(addr, value, mask)  \
    205     (OUTREG(addr, (INREG(addr) & ~mask) | (value & mask)))
     205    (OUTREG(addr, (INREG(addr) & ~(mask)) | ((value) & (mask))))
    206206
    207207
    208208#endif  // _ACCELERANT_H

  • src/add-ons/accelerants/ati/rage128_mode.cpp

     
    304304
    305305    OUTREG(R128_CRTC_GEN_CNTL, params.crtc_gen_cntl);
    306306
    307     OUTREGM(R128_DAC_CNTL, (R128_DAC_MASK_ALL | R128_DAC_8BIT_EN),
     307    OUTREGM(R128_DAC_CNTL, R128_DAC_MASK_ALL | R128_DAC_8BIT_EN,
    308308            ~(R128_DAC_RANGE_CNTL | R128_DAC_BLANKING));
    309309
    310310    OUTREG(R128_CRTC_H_TOTAL_DISP, params.crtc_h_total_disp);
    … …  
    393393
    394394    // Select primary monitor and enable 8-bit color.
    395395    OUTREGM(R128_DAC_CNTL, R128_DAC_8BIT_EN,
    396         (R128_DAC_PALETTE_ACC_CTL | R128_DAC_8BIT_EN));
     396        R128_DAC_PALETTE_ACC_CTL | R128_DAC_8BIT_EN);
    397397    OUTREG8(R128_PALETTE_INDEX, 0);     // set first color index
    398398
    399399    for (int i = 0; i < 256; i++)
    … …  
    436436
    437437    // Select primary monitor and enable 8-bit color.
    438438    OUTREGM(R128_DAC_CNTL, R128_DAC_8BIT_EN,
    439         (R128_DAC_PALETTE_ACC_CTL | R128_DAC_8BIT_EN));
     439        R128_DAC_PALETTE_ACC_CTL | R128_DAC_8BIT_EN);
    440440    OUTREG8(R128_PALETTE_INDEX, first);     // set first color index
    441441
    442442    while (count--) {

  • src/add-ons/accelerants/ati/rage128_dpms.cpp

     
    7272        case B_DPMS_STAND_BY:
    7373            // Screen: Off; HSync: Off, VSync: On.
    7474            OUTREGM(R128_CRTC_EXT_CNTL,
    75                 (R128_CRTC_DISPLAY_DIS | R128_CRTC_HSYNC_DIS), mask);
     75                R128_CRTC_DISPLAY_DIS | R128_CRTC_HSYNC_DIS, mask);
    7676            break;
    7777
    7878        case B_DPMS_SUSPEND:
    7979            // Screen: Off; HSync: On, VSync: Off.
    8080            OUTREGM(R128_CRTC_EXT_CNTL,
    81                 (R128_CRTC_DISPLAY_DIS | R128_CRTC_VSYNC_DIS), mask);
     81                R128_CRTC_DISPLAY_DIS | R128_CRTC_VSYNC_DIS, mask);
    8282            break;
    8383
    8484        case B_DPMS_OFF:

  • src/add-ons/accelerants/ati/rage128_init.cpp

     
    2121// Memory Specifications from RAGE 128 Software Development Manual
    2222// (Technical Reference Manual P/N SDK-G04000 Rev 0.01), page 3-21.
    2323static R128_RAMSpec sRAMSpecs[] = {
    24     { 4, 4, 3, 3, 1, 3, 1, 16, 12, (char *)"128-bit SDR SGRAM 1:1" },
    25     { 4, 8, 3, 3, 1, 3, 1, 17, 13, (char *)"64-bit SDR SGRAM 1:1" },
    26     { 4, 4, 1, 2, 1, 2, 1, 16, 12, (char *)"64-bit SDR SGRAM 2:1" },
    27     { 4, 4, 3, 3, 2, 3, 1, 16, 12, (char *)"64-bit DDR SGRAM" },
     24    { 4, 4, 3, 3, 1, 3, 1, 16, 12, "128-bit SDR SGRAM 1:1" },
     25    { 4, 8, 3, 3, 1, 3, 1, 17, 13, "64-bit SDR SGRAM 1:1" },
     26    { 4, 4, 1, 2, 1, 2, 1, 16, 12, "64-bit SDR SGRAM 2:1" },
     27    { 4, 4, 3, 3, 2, 3, 1, 16, 12, "64-bit DDR SGRAM" },
    2828};
    2929
    3030

  • src/add-ons/mail_daemon/inbound_filters/spam_filter/SpamFilterConfig.cpp

     
    167167{
    168168    char         numberString [30];
    169169    BRect        tempRect;
    170     char        *tempStringPntr;
     170    const char      *tempStringPntr;
    171171
    172172    SetViewColor (ui_color (B_PANEL_BACKGROUND_COLOR));
    173173
    … …  
    209209
    210210    tempRect.right = fNoWordsMeansSpamCheckBoxPntr->Frame().left -
    211211        be_plain_font->StringWidth ("a");
    212     tempStringPntr = (char *)"Spam above:";
     212    tempStringPntr = "Spam above:";
    213213    sprintf (numberString, "%06.4f", (double) fSpamCutoffRatio);
    214214    fSpamCutoffRatioTextBoxPntr = new BTextControl (
    215215        tempRect,
    … …  
    228228
    229229    // Add the box displaying the genuine cutoff ratio, on a line by itself.
    230230
    231     tempStringPntr = (char *)"Genuine below and uncertain above:";
     231    tempStringPntr = "Genuine below and uncertain above:";
    232232    sprintf (numberString, "%08.6f", (double) fGenuineCutoffRatio);
    233233    fGenuineCutoffRatioTextBoxPntr = new BTextControl (
    234234        tempRect,

  • headers/private/graphics/ati/DriverInterface.h

     
    145145    int  readToWriteDelay;  // Read to Write Delay
    146146    int  loopLatency;       // Loop Latency
    147147    int  loopFudgeFactor;   // Add to memReadLatency to get loopLatency
    148     char *name;
     148    const char *name;
    149149};
    150150
    151151