Ticket #7051: Deskbar Persist Expanded State 1.diff

src/apps/deskbar/BarView.cpp

@@ -67 +67 @@
 
 const int32 kMenuTrackMargin = 20;
 
+BList TBarView::sExpandedItems;
+
+
 TBarView::TBarView(BRect frame, bool vertical, bool left, bool top,
         bool showInterval, uint32 state, float, bool showTime)
     : BView(frame, "BarView", B_FOLLOW_ALL_SIDES, B_WILL_DRAW),
@@ -91 +94 @@
     fDragRegion->AddChild(fReplicantTray);
     if (fTrayLocation != 0)
         AddChild(fDragRegion);
+
+    sExpandedItems.MakeEmpty();
 }
 
 
@@ -98 +103 @@
 {
     delete fDragMessage;
     delete fCachedTypesList;
+
+    // Clean up the expanded items list
+    while (!sExpandedItems.IsEmpty())
+        delete static_cast<BString*>(sExpandedItems.RemoveItem((int32)0));
+    sExpandedItems.MakeEmpty();
 }
 
 
@@ -445 +455 @@
     PlaceTray(vertSwap, leftSwap, screenFrame);
 
     // We need to keep track of what apps are expanded.
-    BList expandedItems;
-    BString* signature = NULL;
-    if (fVertical && Expando()
-        && static_cast<TBarApp*>(be_app)->Settings()->superExpando) {
+    SaveExpandedItems();
+
+    PlaceApplicationBar(screenFrame);
+    SizeWindow(screenFrame);
+    PositionWindow(screenFrame);
+    Window()->UpdateIfNeeded();
+
+    // Re-expand those apps.
+    ExpandItems();
+    Invalidate();
+}
+
+
+void
+TBarView::SaveExpandedItems()
+{
+    if (fExpando) {
         // Get a list of the signatures of expanded apps. Can't use 
         // team_id because there can be more than one team per application
-        if (fVertical && Expando() && vertical && fExpando) {
-            for (int index = 0; index < fExpando->CountItems(); index++) {
-                TTeamMenuItem* item
-                    = dynamic_cast<TTeamMenuItem*>(fExpando->ItemAt(index));
-                if (item != NULL && item->IsExpanded()) {
-                    signature = new BString(item->Signature());
-                    expandedItems.AddItem((void*)signature);
+        for (int32 teamIndex = fExpando->CountItems(); teamIndex-- > 0;) {
+            TTeamMenuItem* teamItem
+                = dynamic_cast<TTeamMenuItem*>(fExpando->ItemAt(teamIndex));
+            if (teamItem == NULL || teamItem->Signature() == NULL ||
+                *teamItem->Signature() == '\0')
+                continue;
+
+            if (teamItem->IsExpanded()) {
+                // Expanded, if signature is not in the list add it
+                bool shouldAdd = true;
+                for (int32 sigIndex = sExpandedItems.CountItems();
+                    sigIndex-- > 0;) {
+                    BString *signature =
+                        (BString *)sExpandedItems.ItemAt(sigIndex);
+                    if (signature->ICompare(teamItem->Signature()) == 0) {
+                        // already in the list, don't add the signature
+                        shouldAdd = false;
+                        break;
+                    }
+                }
+                if (shouldAdd) {
+                    // Add the signature to the list
+                    BString* signature = new BString(teamItem->Signature());
+                    sExpandedItems.AddItem((void*)signature);
                 }
             }
         }
     }
+}
 
-    PlaceApplicationBar(screenFrame);
-    SizeWindow(screenFrame);
-    PositionWindow(screenFrame);
-    Window()->UpdateIfNeeded();
-
-    // Re-expand those apps.
-    if (expandedItems.CountItems() > 0) {
-        for (int sigIndex = expandedItems.CountItems(); sigIndex-- > 0;) {
-            signature = static_cast<BString*>(expandedItems.ItemAt(sigIndex));
-            if (signature == NULL)
+void
+TBarView::ExpandItems()
+{
+    if (fExpando && sExpandedItems.CountItems() > 0 && fVertical && Expando()
+        && static_cast<TBarApp*>(be_app)->Settings()->superExpando) {
+        // Start at the 'bottom' of the list working up.
+        // Prevents being thrown off by expanding items.
+        for (int32 teamIndex = fExpando->CountItems(); teamIndex-- > 0;) {
+            TTeamMenuItem* teamItem
+                = dynamic_cast<TTeamMenuItem*>(fExpando->ItemAt(teamIndex));
+            if (teamItem == NULL || teamItem->Signature() == NULL
+                || *teamItem->Signature() == '\0')
                 continue;
 
-            // Start at the 'bottom' of the list working up.
-            // Prevents being thrown off by expanding items.
-            for (int teamIndex = fExpando->CountItems(); teamIndex-- > 0;) {
-                TTeamMenuItem* item
-                    = dynamic_cast<TTeamMenuItem*>(fExpando->ItemAt(teamIndex));
-                if (item != NULL && !signature->Compare(item->Signature())) {
-                    item->ToggleExpandState(false);
+            for (int32 sigIndex = sExpandedItems.CountItems();
+                sigIndex-- > 0;) {
+                BString* signature =
+                    (BString *)sExpandedItems.ItemAt(sigIndex);
+
+                if (signature->ICompare(teamItem->Signature()) == 0) {
+                    teamItem->ToggleExpandState(false);
+                    sExpandedItems.RemoveItem(sigIndex);
                     break;
                 }
             }
         }
 
-        // Clean up expanded signature list.
-        while (!expandedItems.IsEmpty()) {
-            delete static_cast<BString*>(expandedItems.RemoveItem((int32)0));
-        }
+        // Clean up the expanded items list
+        while (!sExpandedItems.IsEmpty())
+            delete static_cast<BString*>(sExpandedItems.RemoveItem((int32)0));
+        sExpandedItems.MakeEmpty();
 
         fExpando->SizeWindow();
     }
-
-    Invalidate();
 }
 
 

src/apps/deskbar/BarView.h

@@ -145 +145 @@
         void PlaceBeMenu();
         void PlaceTray(bool vertSwap, bool leftSwap, BRect screenFrame);
         void PlaceApplicationBar(BRect screenFrame);
+        void SaveExpandedItems();
+        void ExpandItems();
 
         TBarMenuBar* fBarMenuBar;
         TExpandoMenuBar* fExpando;
@@ -171 +173 @@
         uint32 fMaxRecentApps;
 
         TTeamMenuItem* fLastDragItem;
+        static BList sExpandedItems;
 };