Changes between Initial Version and Version 1 of Ticket #11132, comment 2


Ignore:
Timestamp:
Aug 14, 2014, 8:57:59 PM (10 years ago)
Author:
waddlesplash

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11132, comment 2

    initial v1  
    11OK, first dissection:
    22
    3 [http://grok.bikemonkey.org/source/xref/haiku/src/kits/interface/TextView.cpp#GetText BTextView::GetText] calls [http://grok.bikemonkey.org/source/xref/haiku/src/kits/interface/textview_support/TextGapBuffer.cpp#250 the second prototype of TextGapBuffer::GetString]^1^ which does some simple math to figure out where to {{{memcpy}}} to/from. Meanwile, [http://grok.bikemonkey.org/source/xref/haiku/src/kits/interface/textview_support/TextGapBuffer.cpp#134 the first prototype of TextGapBuffer::GetString] also takes {{{fGapCount}}} and {{{fGapIndex}}} into account, and while I wasn't dealing with styled text here I don't think that's the case, the logic differences between the two don't feel right.
     3[http://grok.bikemonkey.org/source/xref/haiku/src/kits/interface/TextView.cpp#GetText BTextView::GetText] calls [http://grok.bikemonkey.org/source/xref/haiku/src/kits/interface/textview_support/TextGapBuffer.cpp#250 the second prototype of TextGapBuffer::GetString]^1^ which does some simple math to figure out where to {{{memcpy}}} to/from. Meanwhile, [http://grok.bikemonkey.org/source/xref/haiku/src/kits/interface/textview_support/TextGapBuffer.cpp#134 the first prototype of TextGapBuffer::GetString] also takes {{{fGapCount}}} and {{{fGapIndex}}} into account, and while I wasn't dealing with styled text here I don't think that's the case, the logic differences between the two don't feel right.
    44
    55