Opened 10 years ago
Closed 7 years ago
#11343 closed enhancement (fixed)
Locale prefs formatting doesn't work on time in Tracker
| Reported by: | humdinger | Owned by: | pulkomandy |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Kits/Locale Kit | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
This is hrev48029.
I've set the formatting in the Locale prefs to German, but checked the box to "use month/day-names from preferred language" (which is English).
With this Tracker shows the "Modified" column like this:
The German "um" should be "at", English like the rest of the date.
We may want to change that option to "Use date/time names from preferred language"?
I guess this is a Tracker issue?
Attachments (2)
Change History (14)
by , 10 years ago
| Attachment: | locale_time.png added |
|---|
comment:2 by , 10 years ago
| Component: | Kits/libtracker.so → Kits/Locale Kit |
|---|---|
| Owner: | changed from to |
| Type: | bug → enhancement |
Tracker is using Locale Kit for the formatting, and using it correctly. The problem seems to be that te unusual english/german mix isn't handled well. I'm not really surprised by this. The "um" is part of the german format, if you want an "at" there you need to use an english format.
We can't do better than this, and the checkbox labelling reflects it. So it would seem there is no bug here ;)
comment:3 by , 10 years ago
OK. Maybe we could mitigate the awkwardness by using the same delimiter as between name of the day and the date: "," ? So that'd be "Wednesday, 7. May 2014, 17:16:25". Sort of like the shorter version for narrower columns is already, e.g. "07.05.2014, 17:16".
comment:4 by , 10 years ago
We don't have much control on this, as ICU decides which format is appropriate. For example in French there are no separators at all. There can't be an automatic solution to this,which is why I don't like this checkbox much.
In the early versions of the locale preflet the formats were completely customizable, but it was decided that the UI was too complex and the idea was dropped.
comment:5 by , 10 years ago
We could
- add a non-UI option to set the date/time format using a standard formatter string.
- patch the known issues of the time/date format strings. In this case, I think there is no need for neither "at" nor "um".
comment:6 by , 8 years ago
Related issue: on hrev51048, inconsistent formatting between AM and PM times (", " for PM, " at " for AM).
by , 8 years ago
| Attachment: | tracker_format_error.png added |
|---|
comment:7 by , 8 years ago
| patch: | 0 → 1 |
|---|
comment:8 by , 8 years ago
| patch: | 1 → 0 |
|---|
follow-up: 10 comment:9 by , 8 years ago
@Duggan: it's just that Tracker decides for each item, the longest format it can fit in the column. In your case, the line with PM would be slightly longer with the full format and wouldn't fit. So, it goes with a shorter format which doesn't include the "at" and uses 3 letter month names. Enlarge or shrink the column and see how this changes. It is not related at all to AM/PM, except maybe because P takes more horizontal space than A?
Maybe we should just remove the longest formats from the list?
comment:10 by , 8 years ago
Replying to pulkomandy:
Maybe we should just remove the longest formats from the list?
+1 to that. It unnecessarily ruffles the columns on resize for no real gain.
comment:11 by , 8 years ago
It is as easy as removing some entries from the list here: http://cgit.haiku-os.org/haiku/tree/src/kits/tracker/WidgetAttributeText.cpp#n205
(and adjusting the loop just below to not use hardcoded "5" and use array_count or similar instead).
comment:12 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Done in hrev51300, and I think it removes most of the hardcoded strings.
Tracker screenshot