Changes between Initial Version and Version 1 of Ticket #11518, comment 13


Ignore:
Timestamp:
Mar 10, 2016, 5:36:43 AM (8 years ago)
Author:
dsizzle

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11518, comment 13

    initial v1  
    1 Thanks for the comments, korli and pulkomandy.  There were seveal new items to learn so I didn't expect to get them right the first time! :)
     1Thanks for the comments, korli and pulkomandy.  There were several new items to learn so I didn't expect to get them right the first time! :)
    22
    33I've attached a new patch to address these items:
    44
    551- removed change to DefaultBuildprofiles
    6 2- added code to only mirror what OpenSSl does; if fontconfig isn't available it's not used at all
    7 3- I had changed the public API initially because it wasn't actually used by anything in the Haiku codebase, and I didn't  suspect any 3rd-party dev would've used it.  unicode_block is basically just an arbitrary BeOS bitfieldt that would be basically useless without something like BFont::Blocks.In any case, I think my new solution is safer:  I added an overloading constructor to match the old API.  I also reverted all of the old BeOS unicode_block constants so they are identical to what they were before.  This should provide backwards compatibility if anyone actually did use it. 
     62- added code to mirror what OpenSSl does; if fontconfig isn't available it's not used at all.
     73- I had changed the public API initially because it wasn't actually used by anything in the Haiku codebase, and I didn't  suspect any 3rd-party dev would've used it.  unicode_block is basically just an arbitrary BeOS bitfield that would be useless without something like BFont::Blocks. 
     8
     9In any case, I think my new solution is safer:  I added an overloading constructor to match the old API.  I also reverted all of the old BeOS unicode_block constants so they are identical to what they were before.  This should provide backwards compatibility if anyone actually did use it. 
    810
    911*CharacterMap does "use" it but doesn't actually do anything with it.