Changes between Version 1 and Version 2 of Ticket #12105, comment 3


Ignore:
Timestamp:
Jun 2, 2015, 6:37:27 AM (9 years ago)
Author:
ahwayakchih

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12105, comment 3

    v1 v2  
    3131}}}
    3232
    33 (notice the first condition - added missing "!" there :). That would be much better, but still not ideal: don't know if that may happen in practice, but if TargetModel was not container and there would be no item selected, we would still get entry_ref to that weird TargetModel, in which case it probably would be better to ignore whole action and return earlier (and/or show some error message?).
     33(notice the first condition - added missing "!" there :). That would be much better (although line 3228 should still be changed to get entry_ref to parent directory), but still not ideal: don't know if that may happen in practice, but if TargetModel was not container and there would be no item selected, we would still get entry_ref to that weird TargetModel, in which case it probably would be better to ignore whole action and return earlier (and/or show some error message?).