Changes between Initial Version and Version 1 of Ticket #12319, comment 8


Ignore:
Timestamp:
Mar 20, 2017, 10:16:44 PM (7 years ago)
Author:
axeld

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12319, comment 8

    initial v1  
    33I have a few remarks, though:
    44* Please try to follow our [https://www.haiku-os.org/development/coding-guidelines coding style] closely. A good start would be trying hard to not make your changes stand out, but it would be even more appreciated to give the guide itself a read :-)
    5 * Please consider using the BNetworAddressResolver class, as in the example from ttcoder 19 months ago. It has a much nicer API, and would allow you to avoid those stringify macros completely. It's also much less likely to leak any memory with it, although your patch seems to deal with that appropriately.
     5* Please consider using the `BNetworAddressResolver` [1] class, as in the example from ttcoder 19 months ago. It has a much nicer API, and would allow you to avoid those stringify macros completely. It's also much less likely to leak any memory with it, although your patch seems to deal with that appropriately.
     6
     7[1] http://cgit.haiku-os.org/haiku/tree/headers/os/net/NetworkAddressResolver.h