Changes between Initial Version and Version 1 of Ticket #12721, comment 4


Ignore:
Timestamp:
Apr 25, 2017, 3:19:15 PM (8 years ago)
Author:
waddlesplash

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12721, comment 4

    initial v1  
    33This looks mightily suspicious to me for a few reasons:
    44 1. Why does this code exist in the first place (for the generic B_CUT/B_COPY/B_PASTE ...)? Won't the BWindow handle this by default?
    5  2. In addition to the generic B_* messages, it's also forwarding a few k* messages which belong to Tracker and would be unrecognized by a generic view, if one were focused.
     5 2. In addition to the generic B_* messages, it's also forwarding a few k* messages which belong to Tracker and would be unrecognized by a generic view, if one were focused (and thus probably cause the infinite recursion seen here).
    66 3. It's also locking the looper of the focused view. Why? The view will necessarily be a child view of this window, no? So why does its looper (our looper) need to be locked?