Changes between Initial Version and Version 3 of Ticket #14930


Ignore:
Timestamp:
Aug 2, 2020, 3:29:58 PM (4 years ago)
Author:
pulkomandy
Comment:

Modified version of the patch applied in hrev54486. The first problem still remains.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #14930 – Description

    initial v3  
    111: If I want to save the png exports to the same directory, I’m asked if I want to overwrite the original, but the export files are supposed to have different filenames (''MyIcon'' becomes ''MyIcon_{64|16|32}.png''). Confirming this will not overwrite the original file at all.
    22
    3 2: If the filename is too long, it will be truncated without appending the proper extension, resulting in the exported filenames all being the same. So Instead of ''LONGNAME'' being saved to ''TRUNCATED_{64|16|32}.png'' there is only 1 file with a truncated name. The issue is in the file src/apps/icon-o-matic/document/savers/BitmapSetSaver.cpp.
     3~~2: If the filename is too long, it will be truncated without appending the proper extension, resulting in the exported filenames all being the same. So Instead of ''LONGNAME'' being saved to ''TRUNCATED_{64|16|32}.png'' there is only 1 file with a truncated name. The issue is in the file src/apps/icon-o-matic/document/savers/BitmapSetSaver.cpp.~~
    44
    5 3: The buffer for the filename is set to the length B_OS_NAME_LENGTH, but it should be B_FILE_NAME_LENGTH. Can be ignored through if you use BString.
     5~~3: The buffer for the filename is set to the length B_OS_NAME_LENGTH, but it should be B_FILE_NAME_LENGTH. Can be ignored through if you use BString.~~