Media_addon_server crash when attempting to reboot or shut down Haiku (Copy2Int())

[vidrep]

hrev53379 x86_64

Since updating to hrev53379 I am experiencing a crash of the media_addon_server whenever I reboot or shutdown Haiku.

On the third attempt I was able to generate a debug report (attached)

[nephele]

This seams to be easily reproducible by asking media_addon_server to quit from the team manager, this gives me a quite similar debug report (i can attach this if that is relevant too)

same hrev for me.

[vidrep]

It seems to only happen after I have been playing a media file. If I have not been playing any media during a session, then Haiku will shut down cleanly. During my last session, it was impossible to shut down Haiku unless I either terminated media_addon_server from the alert notification, or restart the desktop and force a reboot from TeamManager.

[nephele]

Wierd, with asking it to quit from the team monitor the behaviour seams oposite to that, i have had it crash on shutdown without having used any media stuff in a session, if i quit it (and it dies) and subsequently try to play something the media server will be restarted (upon request) and quiting media_addon_server after that doesn't produce a crash anymore.

[X512]

It probably caused by improper cleanup when media_addon_server quit. Crash occured in MultiAudioNode thread which is still active when some dependent resource is released. media_addon_server should stop all nodes it hosts before quit.

[vidrep]

Had it happen again. I've attached the new debug report and syslog.

[leavengood]

I will look at this within the next few days. I am almost done with my current Tracker fix.

I think X512 has the right idea here, though it seems like a pretty basic thing that the media_addon_server would stop all its nodes before quitting...

I just did some quick testing and I cannot seem to reproduce this, but I might not be using the right version of media_addon_server. I am also testing in VirtualBox and whatever version of Intel HD they have doesn't seem to work, and this crash seems to be dependent on that (multi_audio media add-on.) And this machine has a Realtek so I also do not think I would see this if I booted natively. But I'll keep trying.

[leavengood]

Jérôme, you may know this code better than I, any insights? One question I have is why this was commented out: ​https://xref.plausible.coop/source/xref/haiku/src/add-ons/media/media-add-ons/multi_audio/MultiAudioNode.cpp#1294

We suspect this thread is still trying to access buffers after they have been deleted from the BufferCache during shutdown due to my change in hrev53379.

[X512]

Trying to build media_addon_server with debug info by using "DEBUG=1 jam -q media_addon_server", but release build is still produced. media_server debug build complete without problems. What I am doing wrong?

[X512]

I look like problem is in multi_audio add-on. media_addon_server termination sequence seems to be correct. Crash occured when mixer node are released by media_addon_server in _DestroyInstantiatedFlavors. mixer is released before MultiAudioNode, so MultiAudioNode::_OutputThread is still running. MultiAudioNode don't correctly respond to stop and disconnect notifications. Same crash can be also caused by removing connection between "Audio Mixer" and "HD Audio" nodes.

[leavengood]

Thanks for digging into this X512. We have some other media-related bugs about not being able to change the media output without having to reboot afterwards, so I think there is some refactoring that is needed here to decouple the mixer from multi audio. I haven't gotten to that part of the media kit code yet so I still have some things to learn.

[vidrep]

Still here on hrev53528_x86_gcc2. Debug report attached.

[dsuden]

I can confirm this one, am seeing it pretty consistently in latest Haiku 64 bit builds...kind of an "ouch" issue because it hurts credibility a little. I'll attach a report.

[dsuden]

media_addon_server crash at restart - latest Haiku 64 bit version

[ttcoder]

@Dane you could configure debug_server to silently drop media_addon_server when it crashes, much like we did with CC6 quietly-generate-report thing. That's a hackish work-around at best, but then again media_addon_server has been doing that kind of thing for me ever since I started using Haiku in the alpha days (10+ years ago), so expecting a quick resolution might be less reasonable than applying a work-around here :-)

[jmairboeck]

Now that my sound card works with the patched HDA driver (see #15499) I see media_addon_server crashing on shutdown or reboot. Before that fix I did not see the crash. Maybe this helps in finding the cause for this.

[waddlesplash]

Fix merged in hrev53644.

[nephele]

I had another crash on shutdown with media_addon_server on hrev53644, although i am unsure of whether it is the same issue or a different one.

[nephele]

longer report hrev53644

[korli]

Looks like a timing issue then. I can't reproduce anymore at least.

[X512]

Still reproduced on hrev53644 x86_64.

Steps to reproduce:

1. Play some sound.
2. Exit media server by ProcessController -> Quit an Application.
3. media_addon_server will crash.

100% reproducible.

[X512]

Older version (​https://git.haiku-os.org/haiku/tree/src/add-ons/media/media-add-ons/multi_audio/MultiAudioNode.cpp?id=be4e010170a900c3c38b00e17f6104a7bdb938ed) used fBuffer_free semaphore that was deleted later. Maybe it was actually required.

[X512]

Proposed patch: ​https://review.haiku-os.org/c/haiku/+/2053.

[X512]

Disconnecting HD Audio from Audio Mixer in Cortex also do not produce crash after fix.

[korli]

@nephele could you do the following?

• in a Terminal: launch_roster stop x-vnd.haiku-media_server
• then quit media_server with ProcessController
• in Terminal: /system/servers/media_server
• then quit media_server with ProcessController

Please post the log.

[vidrep]

Just updated to hrev53644 and ran a couple of tests. The crash only occurs when a media file with an audio component is played first (see comment:4).

[korli]

@Vidrep you could also try the steps of comment:27

[vidrep]

korli, log.txt attached.

[nephele]

media_server log logg

[nephele]

korli: i have done what you asked, however i could not reproduce a crash this way :/

[korli]

Replying to nephele:

korli: i have done what you asked, however i could not reproduce a crash this way :/

Maybe try to log to a file "/system/servers/media_server 2>&1 1>media_server.log"

[nephele]

How does redirecting file descriptors help? it just did not crash with that test :), i have already added the full log of the test (and media_server) to the ticket

[vidrep]

In my case it did crash. Do you need the debug report in addition to the terminal log?

[Parnikkapore]

I was playing around with this today, and apparently, if you kill the mixer thread ("Yeah baby, very shagadelic") manually first, media_addon_server will not crash on shutdown (Yesterday's hrev)?

Might give a hint as to what's wrong...

[pulkomandy]

Fixed in Fixed in hrev53876.