Changes between Version 1 and Version 2 of Ticket #15751, comment 2


Ignore:
Timestamp:
Feb 29, 2020, 5:19:22 PM (4 years ago)
Author:
nephele

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #15751, comment 2

    v1 v2  
    1010-                       FontStyle* fallbackStyle = gFontManager->GetStyleByIndex(
    1111-                               fallbacks[i], 0);
    12 +                       FontStyle* fallbackStyle = gFontManager->GetStyle(
     12+                      FontStyle* fallbackStyle = gFontManager->GetStyle(
    1313+                               fallbacks[i], font.Style());
    14 +
     14+                      // TODO this does not produce a satisfactory fallback if i.e "extrabold"
     15+                      // is selected since the CJK font does not have that, probably need to
     16+                      // figure out a way to change the font style so that it renders correctly
     17+                      // (render cjk as bold when display is at extrabold or so)
    1518                        if (fallbackStyle != NULL) {
    1619                                ServerFont fallbackFont(*fallbackStyle, font.Size());