[HaikuDepot] build is broken on Haiku

[diver]

This is hrev54121 x86_64.

[waddlesplash]

Strangely, the builds have been completing on the buildbot.

[apl-haiku]

I have just deleted my HaikuDepot build products here and done a re-build;

rm -rf objects/haiku/x86_64/debug_1/apps/haikudepot
DEBUG=1 jam -q HaikuDepot

...and it seems to build OK...

...
C++ objects/haiku/x86_64/debug_1/apps/haikudepot/DumpExportPkgJsonListener.o 
C++ objects/haiku/x86_64/debug_1/apps/haikudepot/DumpExportRepositoryJsonListener.o 
C++ objects/haiku/x86_64/debug_1/apps/haikudepot/DumpExportReferenceJsonListener.o 
Link objects/haiku/x86_64/debug_1/apps/haikudepot/HaikuDepot 
XRes1 objects/haiku/x86_64/debug_1/apps/haikudepot/HaikuDepot 
SetType1 objects/haiku/x86_64/debug_1/apps/haikudepot/HaikuDepot 
MimeSet1 objects/haiku/x86_64/debug_1/apps/haikudepot/HaikuDepot 
SetVersion1 objects/haiku/x86_64/debug_1/apps/haikudepot/HaikuDepot 
Chmod1 objects/haiku/x86_64/debug_1/apps/haikudepot/HaikuDepot 
...updated 111 target(s)...

...locally for me on a Ubuntu 18.04 host.

[waddlesplash]

I can't reproduce this, under GCC2 at least.

[diver]

This is probably because I cross-compile:

git clone --depth=1 https://review.haiku-os.org/buildtools
git clone https://review.haiku-os.org/haiku
cd haiku
mkdir generated
cd generated
../configure --build-cross-tools x86_64 ../../buildtools
jam HaikuDepot

[apl-haiku]

During the HD build there is a python script that takes "schema" from HDS and renders those schema into C++ objects so that the model objects are created automatically and also so that there is some level of compile-time checking against the schema. The compile errors are in the objects that are generate by the python script. The C++ sources that are created by the python are generated. Perhaps there is something going wrong with your environment in relation to this part of the build process. An example of the generated sources are to be found at;

${GENERATED}/objects/haiku/x86_64/common/apps/haikudepot/dumpexportpkgmodel/DumpExportPkg.cpp

Please check the generated sources and check that they are looking OK.

When the build process runs, you can run it with fine-grained logging. Try to do a clean-build with fine-grained logging and see what happens when the python script runs; are there any errors at this stage of the build?

[waddlesplash]

Someone on IRC successfully built haiku.hpkg, including HaikuDepot, on hrev54010, but then after upgrading to current, the new build failed. So this may be due to system headers changes, which seems strange.

[X512]

I have no problems with building nightly-raw including HaikuDepot. Build instructions are same as my posts in ​https://discuss.haiku-os.org/t/building-haiku-x64-from-within-haiku-x64/9319. Maybe deleting objects folder may help.

[waddlesplash]

Indeed, a single job build succeeded here.

[diver]

Removed generated and rebuilt jam HaikuDepot -j2 to see if I can catch any error and got this:

../src/apps/haikudepot/util/LocaleUtils.cpp:8:10: fatal error: unicode/datefmt.h: No such file or directory
 #include <unicode/datefmt.h>
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.

Tried jam HaikuDepot -j2 again and successfully built HaikuDepot.

[waddlesplash]

I think that's an ICU header? So probably there is an undeclared dependency. Why is HaikuDepot not just using the Locale Kit, though?

[pulkomandy]

Should be fixed in ​https://review.haiku-os.org/c/haiku/+/2724 then. And as a bonus the dates are now in the proper localized format.

[waddlesplash]

Done in hrev54217.

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone