Can't push changes to Gerrit

[pulkomandy]

Tried to push some changes to Gerrit and it failed.

It's a rebase of the XFS work on top of current master (Gerrit says they are in merge conflict, wanted to solve that so the code review can continue).

~/opensource/haiku$ git push origin HEAD:refs/for/master
Énumération des objets: 188, fait.
Décompte des objets: 100% (188/188), fait.
Compression par delta en utilisant jusqu'à 8 fils d'exécution
Compression des objets: 100% (103/103), fait.
Écriture des objets: 100% (162/162), 40.87 KiB | 760.00 KiB/s, fait.
Total 162 (delta 132), réutilisés 74 (delta 56)
remote: Resolving deltas: 100% (132/132)
remote: Processing changes: refs: 1, updated: 11, done    
To ssh://review.haiku-os.org/haiku
 ! [remote rejected]       HEAD -> refs/for/master (internal server error: Error inserting change/patchset)
error: impossible de pousser des références vers 'ssh://pulkomandy@review.haiku-os.org/haiku'
~/opensource/haiku$ git push origin HEAD:refs/for/master

Different error on second try (apparently the changes are on the server, but were not processed to update the corresponding change requests):

Énumération des objets: 188, fait.
Décompte des objets: 100% (188/188), fait.
Compression par delta en utilisant jusqu'à 8 fils d'exécution
Compression des objets: 100% (103/103), fait.
Écriture des objets: 100% (162/162), 40.87 KiB | 775.00 KiB/s, fait.
Total 162 (delta 132), réutilisés 74 (delta 56)
remote: Resolving deltas: 100% (132/132)
remote: Processing changes: refs: 1, done    
To ssh://review.haiku-os.org/haiku
 ! [remote rejected]       HEAD -> refs/for/master (no new changes)
error: impossible de pousser des références vers 'ssh://pulkomandy@review.haiku-os.org/haiku'

[pulkomandy]

They are now visible on Gerrit, I guess after someone pushed another change? Not sure what happened, should we close the ticket or keep it open in case it happens again?

[kallisti5]

This has been an ongoing issue for a while from Gerrit. A few days ago I restarted the Gerrit instance because the builders were failing to checkout.. might have been the same issue.

In the past i've traced through the logs, and for some reason over time Gerrit just "stops responding" to our ingress controller mid-stream.

We're currently on Gerrit 3.0.12. The current stable version is 3.2.5.1

Honestly, while the workflow of Gerrit is great, the application itself isn't that great. On the administration side we have been fighting it since it's inception, i've probably blown almost a hundred troubleshooting hours into it at this point over the last 2 years.

[pulkomandy]

The changelog for 3.1 or 3.2 mentions performance improvements and switching to JDK11, maybe that helps (IIRC tqh told us that modern JDKs will run better in containers?).

I would vote Trac (still running on Python2 with no clear plans or schedule for update) as the squeeky wheel still.

But in either case I'd say the cost of switching to something else is still higher (we would need a lot of customization) than going with what we have. Thanks for taking care of the admin side :)

[Coldfirex]

We are on Gerrit 3.2.10 now. Has this popped back up or should we close?

[pulkomandy]

I have not run into problems with Gerrit for a while, I think it's currently working fine.