Opened 3 years ago
Closed 2 years ago
#17065 closed bug (fixed)
WebPositive crashes on https://arstechnica.com/ in WebCore::ResourceHandle::client
| Reported by: | bbjimmy | Owned by: | pulkomandy |
|---|---|---|---|
| Priority: | normal | Milestone: | R1/beta4 |
| Component: | Kits/Web Kit | Version: | R1/beta2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | #17251, #17267 | |
| Platform: | All |
Description
hrev55218 x66_64
navigate to https://arstechnica.com/ and the browser crashes.
Attachments (7)
Change History (23)
comment:1 by , 3 years ago
by , 3 years ago
| Attachment: | WebPositive-114197-debug-07-07-2021-20-30-11.report added |
|---|
crash report
comment:4 by , 3 years ago
Unable to reproduce on hrev55181+45. The site can certainly pause web+ for a while but it eventually came back to life. No crashes that I have been able to notice. Do you have a reproducible way?
comment:6 by , 3 years ago
I was finally able to reproduce on the home screen. I never interacted with the site. Screenshot from CLI perspective.
by , 3 years ago
| Attachment: | terminal-07-23-2021.PNG added |
|---|
comment:7 by , 3 years ago
HaikuWebKit 1.8.2 WebKit 612.1.25
Arstechnica still crashes with latest build from master. Debug log attached
by , 3 years ago
| Attachment: | WebPositive-1063-debug-25-07-2021-17-15-42.report added |
|---|
comment:8 by , 3 years ago
| Blocking: | 17251 added |
|---|
comment:9 by , 3 years ago
| Component: | Applications/WebPositive → Kits/Web Kit |
|---|
comment:10 by , 3 years ago
Looks similar to #10924 which was fixed with this patch. I wonder if it's still applied to https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebCore/platform/network/haiku/BUrlProtocolHandler.cpp#L193
comment:11 by , 3 years ago
In this case, the crash appears to not be a NULL dereference but potentially an uninitialized (or reinitialized with garbage data) pointer use.
comment:12 by , 3 years ago
| Blocking: | 17267 added |
|---|
comment:13 by , 3 years ago
| Summary: | WebPositive crashes on https://arstechnica.com/ → WebPositive crashes on https://arstechnica.com/ in WebCore::ResourceHandle::client |
|---|
comment:14 by , 3 years ago
| Milestone: | Unscheduled → R1/beta4 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:15 by , 3 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
After updating Haikuwebkit in hrev55655 Web+ still crashes with:
0x7faf29404470 0x123b23cc1a0 WebCore::ResourceHandle::client() const + 0
Disassembly:
WebCore::ResourceHandle::client() const: 0x00000123b23cc1a0: 488b4710 mov 0x10(%rdi), %rax <--
by , 3 years ago
| Attachment: | WebPositive-937-debug-23-11-2021-15-04-23.report added |
|---|
hrev55655 debug report
by , 3 years ago
| Attachment: | WebPositive-2096-debug-11-03-2022-15-34-46.report added |
|---|
by , 3 years ago
| Attachment: | WebPositive-11516-debug-13-03-2022-08-12-09.report added |
|---|
comment:16 by , 2 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
This will be fixed in the next haikuwebkit release with https://github.com/haiku/haikuwebkit/commit/5df767d90de2431699a83ee3041b4f524012ec8d
core file: https://fatelk.com/jim/core-WebPositive-114418
Debug report: https://fatelk.com/jim/WebPositive-114197-debug-07-07-2021-20-30-11.report
I couldn't attatch files using either Web+ or Otter ... maybe needs another ticket.