Opened 3 years ago
Last modified 3 years ago
#17196 new bug
Unit tests fail to build - Missing DumpExportRepositorySource.h
Reported by: | Coldfirex | Owned by: | apl-haiku |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Applications/HaikuDepot | Version: | R1/beta3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Unit tests fail to build due to missing DumpExportRepositorySource.h file. hrev55181+55
Attachments (1)
Change History (8)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
The file is generated in the Jamfile
;
HdsSchemaGenAppSrcDependsOnGeneration [ FGristFiles $(generatedPkgParserSourceFiles) ] [ FGristFiles $(generatedPkgParserSourceFiles:S=.h) ] : $(dumpExportPkgBulkListenerTargetFile) ;
follow-up: 4 comment:3 by , 3 years ago
Would you be able to paste in the build trace that failed. I suspect that if HaikuDepot is built first then the files will be available.
comment:4 by , 3 years ago
Replying to apl-haiku:
Would you be able to paste in the build trace that failed. I suspect that if HaikuDepot is built first then the files will be available.
Do you mean just the jam output from the cli or something more than that? If so, it is now attached.
by , 3 years ago
Attachment: | Build_log.txt added |
---|
comment:5 by , 3 years ago
At the top of this trace;
don't know how to make <src!tests!apps!haikudepot>DumpExportRepositorySource.cpp don't know how to make <src!tests!apps!haikudepot>DumpExportRepositorySourceMirror.cpp don't know how to make <src!tests!apps!haikudepot>DumpExportRepository.cpp don't know how to make <src!tests!apps!haikudepot>DumpExportRepositoryJsonListener.cpp
...then later down..
../src/tests/apps/haikudepot/DumpExportRepositoryJsonListenerTest.cpp:6:10: fatal error: DumpExportRepositorySource.h: No such file or directory 3930 #include "DumpExportRepositorySource.h"
I think if you do a jam -q HaikuDepot
first then those sources will have been generated for the compile of the unit tests.
The files are generated in the HaikuDepot project by the Jamfile
and material in .../haikudepot/build
where it takes the schema definitions (from HDS) and uses some python logic to generate C++ source to create model objects and parsers.
comment:6 by , 3 years ago
Yep, that was it. Is that an issue or should we just update the documentation to note that? https://www.haiku-os.org/documents/dev/unit_testing
comment:7 by , 3 years ago
Hmmm good question. Maybe the "unitest" target can depend on the HaikuDepot build product?
Old copy? https://lgtm.com/projects/g/haiku/haiku/snapshot/79d3ab977377fb47199d2ada3dd87efecae8dde1/files/generated/objects/haiku/x86_64/common/apps/haikudepot/dumpexportrepositorymodel/DumpExportRepositorySource.h?sort=name&dir=ASC&mode=heatmap