Changes between Initial Version and Version 1 of Ticket #17258, comment 2


Ignore:
Timestamp:
Sep 24, 2021, 8:27:52 AM (3 years ago)
Author:
nephele

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17258, comment 2

    initial v1  
    1 With a debug build I hit an assertion.
    2 
    3 {{{
    4 ~/proj/haikuwebkit-new/WebKitBuild/Debug ./HaikuLauncher                                                                             
    5 Please note that you don't have secure memory on this system
    6 ASSERTION FAILED: (*bitwise_cast<WTF::Config*>(&WebConfig::g_config[WTF::startSlotOfWTFConfig])).isThreadSuspendResumeSignalConfigured
    7 ../../Source/WTF/wtf/posix/ThreadingPOSIX.cpp(235) : static void WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated()
    8 Abort
    9 }}}
    10 
    11 For completeness, this is what i changed to get Debug to compile:
    12 {{{
    13 diff --git a/Source/WebCore/testing/Internals.cpp b/Source/WebCore/testing/Internals.cpp
    14 index ec2b92a8f5..f8091a2e16 100644
    15 --- a/Source/WebCore/testing/Internals.cpp
    16 +++ b/Source/WebCore/testing/Internals.cpp
    17 @@ -6447,7 +6447,7 @@ constexpr TreeType convertType(Internals::TreeType type)
    18      case Internals::ComposedTree:
    19          return ComposedTree;
    20      }
    21 -    ASSERT_NOT_REACHED();
    22 +    //ASSERT_NOT_REACHED();
    23      return Tree;
    24  }
    25  
    26 diff --git a/Source/WebKitLegacy/haiku/API/WebPage.cpp b/Source/WebKitLegacy/haiku/API/WebPage.cpp
    27 index 3c37295f9b..954a183921 100644
    28 --- a/Source/WebKitLegacy/haiku/API/WebPage.cpp
    29 +++ b/Source/WebKitLegacy/haiku/API/WebPage.cpp
    30 @@ -171,7 +171,7 @@ BMessenger BWebPage::sDownloadListener;
    31         // NOTE: This needs to be called when the BApplication is ready.
    32         // It won't work as static initialization.
    33  #if !LOG_DISABLED
    34 -    WebCore::initializeLogChannelsIfNecessary();
    35 +    //WebCore::initializeLogChannelsIfNecessary();
    36  #endif
    37      PlatformStrategiesHaiku::initialize();
    38  
    39 diff --git a/Source/WebKitLegacy/haiku/WebCoreSupport/IconDatabase.cpp b/Source/WebKitLegacy/haiku/WebCoreSupport/IconDatabase.cpp
    40 index 14eef5f5c6..196758c96e 100644
    41 --- a/Source/WebKitLegacy/haiku/WebCoreSupport/IconDatabase.cpp
    42 +++ b/Source/WebKitLegacy/haiku/WebCoreSupport/IconDatabase.cpp
    43 @@ -1693,7 +1693,7 @@ inline void readySQLiteStatement(std::unique_ptr<SQLiteStatement>& statement, SQ
    44      if (!statement) {
    45          auto temp = db.prepareHeapStatement(str);
    46          if (!statement)
    47 -            LOG_ERROR("Preparing statement %s failed", str.ascii().data());
    48 +            LOG_ERROR("Preparing statement %s failed", str.characters());
    49          else
    50              statement = temp.value().moveToUniquePtr();
    51      }
    52 }}}
     1(wrong ticket sorry!)