Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17263 closed bug (fixed)

Keyboards stopped working after updating to hrev55414

Reported by: mrentropy Owned by: lt_henry
Priority: high Milestone: R1/beta4
Component: Drivers/Input/HID/USB Version: R1/Development
Keywords: Cc: pulkomandy
Blocked By: Blocking:
Platform: All

Description (last modified by mrentropy)

Updated system from hrev55410 to hrev55414 and the keyboard stopped working. Nothing appears when typing and using NUM and CAPS lock keys don't light up the lights. Affected AZIO MK Retro and Razer Deathstalker.

This is a 64-bit system

Attachments (6)

usb_hid_report_descriptor_04d9_a0f8_0.bin (59 bytes ) - added by mrentropy 3 years ago.
AZIO MK Retro (I think)
usb_hid_report_descriptor_04d9_a0f8_1.bin (132 bytes ) - added by mrentropy 3 years ago.
AZIO MK Retro
usb_hid_report_descriptor_04d9_a0f8_2.bin (33 bytes ) - added by mrentropy 3 years ago.
AZIO MK Retro
usb_hid_report_descriptor_1532_0118_0.bin (61 bytes ) - added by mrentropy 3 years ago.
Razer Deathstalker (I think)
usb_hid_report_descriptor_1532_0118_1.bin (159 bytes ) - added by mrentropy 3 years ago.
Razer Deathstalker
usb_hid_report_descriptor_1532_0118_2.bin (94 bytes ) - added by mrentropy 3 years ago.
Razer Deathstalker

Download all attachments as: .zip

Change History (20)

by mrentropy, 3 years ago

AZIO MK Retro (I think)

by mrentropy, 3 years ago

AZIO MK Retro

by mrentropy, 3 years ago

AZIO MK Retro

by mrentropy, 3 years ago

Razer Deathstalker (I think)

by mrentropy, 3 years ago

Razer Deathstalker

by mrentropy, 3 years ago

Razer Deathstalker

comment:1 by mrentropy, 3 years ago

Description: modified (diff)

comment:2 by waddlesplash, 3 years ago

Cc: pulkomandy added
Component: - GeneralDrivers/Input/USB-HID
Keywords: keyboard removed
Milestone: UnscheduledR1/beta4
Owner: changed from nobody to lt_henry
Priority: normalhigh
Status: newassigned

Almost certainly a regression from hrev55413.

comment:3 by lt_henry, 3 years ago

I am looking on it. Mine is working (of course I've tested before pushing the patch). I understand this issue affects only to some keyboards, right?

comment:4 by pulkomandy, 3 years ago

There is only this one report so far, yes (and some people have confirmed their keyboard started working).

comment:5 by vidrep, 3 years ago

My keyboard also stopped working just as described in the ticket.

comment:6 by lt_henry, 3 years ago

I think I got it. Working on it.

comment:7 by vidrep, 3 years ago

If you need a syslog, usb_HID_report, or a patch tested, leave a comment and I’ll try to get you some data.

comment:8 by lt_henry, 3 years ago

I have pushed a patch.

There was a bug introduced effectively, on hrev55413, that prevented most consumer keyboards to be handled by HID KeyboardHandler.

However, the keyboard I have found for testing this bug is sending empty reports and keypress is working quite bad (both lost and repeated types). I dont know if this is still my fault (still looking into it).

in reply to:  2 comment:9 by lt_henry, 3 years ago

Replying to waddlesplash:

Almost certainly a regression from hrev55413.

I got it working with Qemu USB keyboard. Using a real keyboard with qemu usb redirection I get some lost/repeated typing. After debugging a bit, it seems _ReadReport reports pressed keys properly and the bug is somewhere in the _Control method where key repeat code is.

The keyboard sends periodic (~ 1s) empty key reports.

However, this keyboard seems to work nice on an older haiku release.

Tomorrow (GMT+2) I'll continue.

comment:10 by vidrep, 3 years ago

I've applied the patch and am building haiku.hpkg now. I'll report back when it's finished.

comment:11 by vidrep, 3 years ago

Installing haiku.hpkg with patch applied makes the keyboard work again.

in reply to:  11 comment:12 by lt_henry, 3 years ago

Replying to vidrep:

Installing haiku.hpkg with patch applied makes the keyboard work again.

Thanks!

comment:13 by waddlesplash, 3 years ago

Resolution: fixed
Status: assignedclosed

Fix merged in hrev55417.

comment:14 by bronzie94, 3 years ago

Apple A1048 Broken in hrev55415

Version 0, edited 3 years ago by bronzie94 (next)
Note: See TracTickets for help on using tickets.