Changes between Version 1 and Version 2 of Ticket #17314, comment 16


Ignore:
Timestamp:
Oct 15, 2021, 8:56:49 PM (3 years ago)
Author:
rudolfc

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17314, comment 16

    v1 v2  
    44I was testing some hrevs since I saw an unexpected effect on Generation4 (G45) over here: the refreshrate (after the above commit, but also on hrevs before I started working on BWindowScreen, so where proposemode did not yet come into play with setmode) deviates a lot if I set 1280x1024x70Hz: with the old version it sets 76Hz, with the latest commit it's 64Hz. Both about the same error. The reason for the deviation is limits in the PLL hardware so it looks like that can't be helped (easily).
    55
    6 The reason it was 76Hz, and it's now 64Hz, is because via setmode and just visible size check, along with refresh, another modeline is still choosen.
     6The reason it was 76Hz, and it's now 64Hz, is because via setmode calling proposemode with just visible size check, along with refresh, another modeline is still choosen.
    77
    88The better way of choosing the modeline would probably be to look at which mode's defaults come closest to the refreshrate setmode wants to set, so I might still look at that, depending on your results. (please let me know)