#17351 closed bug (fixed)
WebPositive (master) crashes on Amazon.ca
| Reported by: | vidrep | Owned by: | pulkomandy |
|---|---|---|---|
| Priority: | normal | Milestone: | R1/beta4 |
| Component: | Applications/WebPositive | Version: | R1/beta3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
hrev55576 x86_64
HaikuWebKit 1.8.2
WebKit 613.1.5
WebPositive consistently crashes after logging into my account and accessing the order history
Debugger report attached
Attachments (3)
Change History (12)
by , 3 years ago
| Attachment: | WebPositive-14004-debug-23-10-2021-19-02-17.report added |
|---|
comment:1 by , 3 years ago
comment:2 by , 3 years ago
I would revert that commit for now, we can always investigate later if we can do something more inteligent here, but reverting would bring us in line with what upstream does here.
For me i cannot reproduce the crash, but then I don't know if WASM works for me either, pretty much everything I wanted to test complained about WebGL instantly, so perhaps that didn't actually load any WASM code (or one that is relevant to provoke this crash)
comment:3 by , 3 years ago
Tested: Haiku R1B3 (+62) w/ Web+ (HaikuWebkit 1.8.2, Webkit 613.1.5)
Before/After GigaCage change, bug still fails on Haiku R1B3 x86_64 (+62). Works on R1B3 x86 (+62).
comment:4 by , 3 years ago
I have attached a debugger report from the locked Amazon.ca page as requested by nephele yesterday on IRC
by , 3 years ago
| Attachment: | WebPositive-996-debug-25-10-2021-17-41-58.report added |
|---|
comment:5 by , 3 years ago
I have also attached the terminal output from yesterday, just in case it is of use in debugging
by , 3 years ago
comment:6 by , 3 years ago
The freeze is unrelated to the crash, anyhow. It looks like this is the same freeze with IconDatabase that another ticket was complaining about.
comment:7 by , 3 years ago
The crash should be fixed by https://github.com/haiku/haikuwebkit/commit/4b856d5751553a537258771757ebeece3b39c4d9; please test.
comment:8 by , 3 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Vidrep reports it is indeed fixed.
comment:9 by , 3 years ago
| Milestone: | Unscheduled → R1/beta4 |
|---|
Vidrep reports on IRC that reverting https://github.com/haiku/haikuwebkit/commit/44871cb0e724924eb5128ada6aa2c8dacd8b42b8 fixed this problem (the conversation was a bit hard to follow but I think that was what was said.) That would indicate we need to do something different here instead of reserveUncommitted.