Changes between Initial Version and Version 1 of Ticket #17852, comment 17


Ignore:
Timestamp:
Jan 27, 2023, 5:33:14 PM (22 months ago)
Author:
pulkomandy

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17852, comment 17

    initial v1  
    44
    55The access to the operand is done using IEM_OPCODE_GET_NEXT_S32_SX_U64 which can be implemented in various different ways depending on both compile time and runtime factors. All it takes is one of these variants being incorrect. I checked some of them and they look ok, relying on the C compiler to do the sign extension by doing some casts between different types.
     6
     7In VBox 1.6.30 this macro was defined in IEMAll.cpp but it is not there anymore. It ended up calling functions like https://www.virtualbox.org/browser/vbox/trunk/src/VBox/VMM/VMMAll/IEMAll.cpp?rev=96860#L1419 (or the non-slow variant if possible).