Changes between Initial Version and Version 1 of Ticket #18203, comment 18


Ignore:
Timestamp:
Apr 17, 2023, 11:37:16 PM (14 months ago)
Author:
ambroff

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18203, comment 18

    initial v1  
    1212
    1313In the case where there is data in the send queue, this code is breaking that data up into segments of the size 256 bytes regardless of what the max segment size (MSS) is set to. Elsewhere the MSS seems to be calculated appropriately, which is something like MTU - 20, where 20 is the TCP header overhead.
     14
     15Sending segments of the size MSS when possible and more closely aligning the allocation with the size of the segment itself would probably yield better results. But I think the throughput would be even better if a large allocation was made that packed multiple segments up to size MSS inside of it would be better. That seems to be a bit incompatible with the design of the network stack unfortunately I'm not sure how difficult that would be at the moment.