Opened 17 months ago

Closed 17 months ago

#18469 closed bug (fixed)

Get/Set Alignment missing implementations on BMessage (easy)

Reported by: kallisti5 Owned by: nobody
Priority: normal Milestone: R1/beta5
Component: Kits/Application Kit Version: R1/beta4
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

​https://git.haiku-os.org/haiku/commit/?id=6e50e79e543 introduced GetAlignment / SetAlignment calls in the BMessage header, however nothing actually implements these within the application kit.

Discovered by trungnt2910.

Change History (5)

comment:1 by kallisti5, 17 months ago

A little further context, ​https://git.haiku-os.org/haiku/commit/?id=b1008df2c2007091bdda65b6dbb8ba9362ffbd09 introduced FindAlignment which is implemented correctly

These are all undocumented. ​https://www.haiku-os.org/legacy-docs/bebook/BMessage.html

comment:2 by waddlesplash, 17 months ago

Component: - General → Kits/Application Kit

comment:3 by pulkomandy, 17 months ago

Summary: Get/Set Alignment missing implementations on BMessage → Get/Set Alignment missing implementations on BMessage (easy)

All we need is adding a

DEFINE_SET_GET_BY_REFERENCE_FUNCTIONS(BAlignment, Alignment, B_ALIGNMENT_TYPE);

So it seems easier to submit a patch than to create a ticket for it?

Version 0, edited 17 months ago by pulkomandy (next)

comment:4 by X512, 17 months ago

Submitting patch is more difficult because it can't be done with web interface.

comment:5 by waddlesplash, 17 months ago

Milestone: Unscheduled → R1/beta5
Resolution: → fixed
Status: new → closed

Fixed in hrev57125.

Note: See TracTickets for help on using tickets.