Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#18737 closed bug (fixed)

[registrar] List of recent Docs/Folders/Apps seems to grow indefinitely.

Reported by: bipolar Owned by: nobody
Priority: normal Milestone: R1/beta5
Component: Servers/registrar Version: R1/beta4
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

While trying to find a way to clear the list of "Recent Folders"...

I've noticed that my ~/config/settings/system/registrar/RosterSettings file was over 570 KB (On my 64 bits install... I have one over 360 KB on my 32 bits beta4).

+3100 "RecentDoc" lines, +1000 "RecentFolder" lines, and 120+ "RecentApp" seems a bit excessive :D

Reading, under haiku/src/servers/registrar/, TRoster.{h,cpp}, and Recent{Apps,Entries}.{h,cpp}...

I can't find an upper bound to the grow of any of those 3 lists, just std::list::push_front() for new/unique entries, and no limit while saving them to file (unless I'm reading it wrong, of course).

Change History (3)

comment:1 by bipolar, 11 months ago

Some crude "reversing" (strings /boot/beos/system/registrar | grep -i recent, and c++filt) seems to indicate that that BeOS's registrar did limit the number of entries on the RosterSettings file, via a RecentItemsDict::TrimToCount() method.

I *might* try to find what BeOS' limits were, for "fun" at least.

comment:2 by waddlesplash, 10 months ago

Milestone: UnscheduledR1/beta5
Resolution: fixed
Status: newclosed

Fixed in hrev57547.

comment:3 by bipolar, 10 months ago

Heh, forgot to report back here...

FWIW, after some crude bash scripting, and lots of reboots, on BeOS.... seems BeOS' limits are around 200 for apps, 40 for docs, 20 for folders. But seems it allows you to go way up above those limits before actually trimming them down.

100 for everything sounds good to me, in any case. Thanks!

Version 0, edited 10 months ago by bipolar (next)
Note: See TracTickets for help on using tickets.