Changes between Version 1 and Version 2 of Ticket #3897, comment 16


Ignore:
Timestamp:
Jul 25, 2010, 9:29:09 AM (14 years ago)
Author:
dru_ed

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3897, comment 16

    v1 v2  
    1111The 3 rows, which are conceptually parents, are removed by what is the "else" code that seemed to have been meant for children, not parents. This is where the 3 rows are removed and with "fItemsHeight -= subTreeHeight + 1;"
    1212
    13 Is it enough to only compensate for the height of children a parent had when delete? Perhaps, but that may be no better than the patch which set fItemsHeight to 0, treating symptoms not illness. I'm not facile enough with the OutlineView code to know if there's a deeper conceptual problem but I was surprised the UI "parent" rows are removed by "child" code.
     13Is it enough to only compensate for the height of children a parent had when deleted? Perhaps, but that may be no better than the patch which set fItemsHeight to 0, treating symptoms not illness. I'm not facile enough with the OutlineView code to know if there's a deeper conceptual problem but I was surprised the UI "parent" rows are removed by "child" code.
    1414
    1515I would suggest looking closer at the FindParent call. In particular does "parentRow" (called "outParent" in FindParent code) act as expected since the parents are handled as children and if (parentRow) code is not executed.