Opened 14 years ago

Last modified 14 years ago

#6497 closed bug

MediaConverter does not handle errors gracefully when sniffing files (easy) — at Version 2

Reported by: yourpalal Owned by: yourpalal
Priority: normal Milestone: R1
Component: Applications/MediaConverter Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description (last modified by yourpalal)

MediaFileInfo::LoadInfo() ignores many return codes and can end up with a GIGO situation. Some examples are:

*should check track->InitCheck() after getting the track from TrackAt()

(MediaFileInfo.cpp:37)

*should check return of track->EncodedFormat()

(MediaFileInfo.cpp:39)

*should check return of track->DecodedFormat()

(MediaFileInfo.cpp:43)

*should check return of track->GetCodecInfo()

(MediaFileInfo.cpp:46)

There are similar problems when sniffing audio tracks (MediaFileInfo.cpp:58-88)

Once those are fixed, LoadInfo() should also return a status_t, which should be checked in MediaFileInfoView::Update().

Change History (2)

comment:1 by yourpalal, 14 years ago

Component: ApplicationsApplications/MediaConverter

comment:2 by yourpalal, 14 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.