Add "Open in new window/tab" in context menu

[humdinger]

This is hrev547.

Context menus on links should offer to "Open in new window" and "Open in new tab". ATM you can only open in new tab window.

[leavengood]

Should be easy enough. I'll take this over.

[pulkomandy]

Not as easy as it looks. The menu is on WebKit side.

[luroh]

Moving Web+ enhancements out of R1 milestone.

[nephele]

On hrev53242 this functionality seams to be included, it seams to be broken since both options open links in a new in-window tab.

[pulkomandy]

Yes, I started doing this, added the menu and then remembered that WebKit doesn't know the difference between "new tab" and "new window", that is entirely handled on the browser side.

Maybe webkit2 will allow us to move management of this menu outside of WebKit and have more control on what we put in it.

[bitigchi]

Upvoted.

[pulkomandy]

Well, we can change the context menu in WebKit so that's not exactly the problem. The problem is the WebKitLegacy API doesn't have (that I know) a distinction between tabs and windows. When you want to open a link you can specify "use this same tab/window", "use a new one", or "this is a download, don't open anything", and that's it.

I'm not sure Safari even used the WebKit1 API itself, this API was introduced for iOS apps to embed a web view or something like that and Safari probably did use more direct access to the WebKit internals. Which we could do as well, but at this point we should just shitch to WebKit2 and do this once we have migrated.