Changes between Initial Version and Version 1 of Ticket #7285, comment 28
- Timestamp:
- Jun 5, 2011, 9:34:20 AM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #7285, comment 28
initial v1 12 12 13 13 The patch introduces a queued_time field, set on event creation. You even base the "lateness" calculation on that. 14 But this is very strange. it should be possible to create 10 events, give them performance time stamps when they should be played, and place them into the queue. The are not late unless they get removed from the queue after their performance time has passed. Your lateness calculation makes them appear to be late, just because they were queued early.14 But this is very strange. it should be possible to create 10 events, give them performance time stamps when they should be played, and place them into the queue. They are not late unless they get removed from the queue after their performance time has passed. Your lateness calculation makes them appear to be late, just because they were queued early. 15 15 16 16 In: "lateness = 0; // remove any extraneous value if we get this far " 17 it appears your patch sets lateness always to zero before calling DispatchEvent, finally 18 dropping the information how late the event is played. Why?17 18 it appears your patch sets lateness always to zero before calling DispatchEvent, finally dropping the information how late the event is played. Why? 19 19 20 20 I can't recommend applying this patch.