[Debugger] odd Terminal launch

[diver]

This is hrev42754, gcc4hybrid.

Looking at Teams window of the Debugger app and launching Terminal shows somewhat odd behavior:

• /bin/bash appears and disappears several times under different IDs.
• There are two Terminal entries in the Teams window with different IDs.
• There is no /bin/bash in that list until Debugger restart.
• Sometimes Terminal's icon appears as generic app icon.

[anevilyak]

Some of parts 1 and 2 isn't a complete surprise because of the fork/execs that go on in the process of spawning the child bash (which itself does some more of this in order to run the env setup scripts, etc.). Probably an exec gets missed somewhere resulting in the team not properly getting updated to reflect its new running executable image. Phiippe has done more with the teams window though, so he might have better insight.

[phoudoin]

I guess indeed that the current code don't handle fine the fork/exec case. So, depending on when the update code run; you can have:

• Two Terminals teams, due to the fork: the exec are not yet done for the child team...
• after an exec done by a team already detected in previous cycle, the team name and/or icon is not updated according to the new running image and still show its former parent attributes.
• depending on when the icon is retrieved, it could be the one from before or after the exec: icon is retrieved in a lazy/deferred way (at drawing time), it would explain why the end icon is not always either wrong or right. In this Terminal icon case, it's either the (just) forked Terminal icon or the (new) /bin/bash (generic app icon) which was exec'ed in its place.

So, I guess I should redesign it a bit in order to handle the fork/exec case, indeed. I fear Process Controller teams menu could suffer the same issue here, BTW.

[phoudoin]

Fixed in hrev42755.

[phoudoin]

Re-opened as hrev42755 wasn't fixing it correctly. Do an explicit row update when needed now in hrev42756.

This time, I'll wait the green light before closing the ticket :-)

[anevilyak]

Looks fixed over here...diver, can you confirm?

[diver]

Apart from the second Terminal with id 1041 and the fact that it takes 4-5 seconds for Terminal to start in vbox everything is fine now.

[phoudoin]

Thanks you for (video!) report.