Changes between Initial Version and Version 1 of Ticket #7996, comment 2


Ignore:
Timestamp:
Sep 24, 2011, 1:34:09 PM (13 years ago)
Author:
anevilyak

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7996, comment 2

    initial v1  
    11Unfortunately, this patch cannot be applied as is ; it breaks binary compatibility in a number of ways:
    22
    3 1) It changes the signature of the existing constructor, which will result in symbol resolution failures since this results in the mangled name changing.
     31) It changes the signature of the existing constructor, which will result in symbol resolution failures since this results in the mangled name changing. In general, you cannot change the signature of existing public functions.
    44
    552) It adds an extra virtual ; one cannot change the number or order of virtual functions due to the fragile base class problem. BSlider has several reserved virtual slots for exactly this reason, you would need to instead replace the first one of those with your new virtual, and also add a compat placeholder to dispatch the old name.