Changes between Initial Version and Version 1 of Ticket #8615, comment 3


Ignore:
Timestamp:
May 30, 2012, 1:54:28 AM (12 years ago)
Author:
kallisti5

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #8615, comment 3

    initial v1  
    11I gave it a quick run over... it all looks really good. There were a few quirks with 3 vs two 2 returns before and after functions, however otherwise it passes the style smell test.
    22
    3 I do worry a little about some of the licensing in the i810_* files changing as-is copyrights to mit can be tricky. (although you did document the original license, so those concerns may be moot.
     3I do worry a little about some of the licensing in the i810_* files, changing as-is copyrights to mit can be tricky. (although you did document the original license, so those concerns may be moot)
    44
    55Great work!!!  umccullough, interested in your test results :)