usb_floppy doesn't function and causes kdl when unplugged

[kallisti5]

• Plug a usb floppy drive into a running Haiku system
• See the following in syslog:

usb_floppy: device reports a lun count of 1
usb_floppy: getting inquiry data failed
usb_floppy: failed to initialize logical units

KDL On unplug:

Breakpoint exception in kernel mode
Thread 38, uhci finish thread
.
.
<kernel_x86>:panic
<kernel_x86>:x86_handle_breakpoint_exception + 0x0025
<kernel_x86>:int_bottom + 0x003d
<uhci> UHCI<0x82817150>::FinishTransfers(0x0)
<uhci> UHCI<0x82817150>::FinishThread(NULL)
<kernel_x86> common_thread_entry

[mmu_man]

Actually I didn't write this one :p

[pulkomandy]

Well, it worked with the two drives I have at home last time I checked, and I don't remember seeing such KDL.

Was there a floppy in the drive when you plugged it ?

[kallisti5]

Yup.. I thought of that. Same result if a floppy disk is present or not present.

[scottmc]

did you "unmount" the usb floppy drive before unplugging it? I know if you unplug a usb flash device without first unmounting you'll end up in kdl, so perhaps this is similar?

[pulkomandy]

Unscheduling this for beta1. My hardware works, and this is quite unlikely to be useful to anyone except me anyway.

[pulkomandy]

Welp, playing with usb_floppy again and now I can reproduce the issue with both my drives.

Something must have changed somewhere in the USB stack (EHCI in my case, so in the generic code shared between UHCI and EHCI).

[korli]

Should this ticket be closed after the merge with usb_disk?

[pulkomandy]

No KDL anymore, but the driver still doesn't work for floppies.

[waddlesplash]

Please retest after hrev57051.

[Luposian]

Has anyone tested this out yet?

[cocobean]

Test drive I have is the Chuanganzhou USB 2.0 model - "Floppy Disk Reader, 3.5 inch External USB Type C Floppy Disk Drive for Laptop and Desktop, Black, Frosted Texture"

USB floppies not claimed to work yet. So, I can review basic mount/unmount of drive and floppy.

Haiku R1B5 (hrev57937+36) x86_gcc2 (no floppy media inserted in drive):

1. Boot up to desktop - USB floppy drive attached: KDL before desktop or "install/try Haiku" GUI.
2. Desktop - attach USB drive: possible KDL (random). Driver mostly stable during init with no KDL.
3. Desktop - unattaching USB drive: KDL (consistently happens).
4. Shutdown from desktop - USB floppy drive attached: No KDL - but does not shutdown completely. (test incomplete, same issue if USB drive unattached)

[pulkomandy]

Can you open your own ticket please, since your error message is different from the ones in either of these existing tickets (which had been kept separate because they have different problems).

[waddlesplash]

Please retest after hrev58221.