BDirectWindow::SupportsWindowMode() doesn't check for hardware cursor support

[jua]

According to the BeBook, windowed mode for BDirectWindow should only work when the graphics accelerant supports hardware cursors (see the documentation on BDirectWindow::SupportsWindowMode()).

SupportsWindowMode() is supposed to check for it, however, in Haiku it only looks for B_PARALLEL_ACCESS. Using a BDirectWindow without hardware cursor causes any drawing in it to even draw over the mouse cursor.

The attached patch adds B_HARDWARE_CURSOR to the check.

[jua]

Add hw cursor checking

[jua]

I just learned about this ticket: ​http://dev.haiku-os.org/ticket/4356

If #4356 is implemented, this patch is not necessary anymore, because then hardware cursor is not a requirement for BDirectWindow... (although then there is no cursor in it).

[pulkomandy]

Applying this as is would essentially make windowed BDirectWindow unusable, since very few of our drivers support hardware cursors. We should probably fix that first.

[rudolfc]

Guys,

Let it please be noted that my drivers all have 100 procent correct working hardware cursors under beos hrev5 and dano. These drivers are: Nvidia, matrox, neomagic and via. If its not working correctly, the problem lies somewhere else.

Bye!,

Rudolf.

[rudolfc]

BTW,

For these driver's there is HTML doc in the respective kerneldriver source folders, alongside the settings files for these drivers (all same style).

Rudolf.

[pulkomandy]

Marking as duplicate of 4356, whichever solution we settle on in the end, we don't need multiple tickets to track it.