Opened 11 years ago
Last modified 11 years ago
#9481 closed bug
[patch] BMenuBar_Track() is not locking atomically — at Initial Version
| Reported by: | jscipione | Owned by: | axeld |
|---|---|---|---|
| Priority: | high | Milestone: | R1 |
| Component: | Kits/Interface Kit | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | #8539 | |
| Platform: | All |
Description
Because the locking is not-atomic it can cause the app to crash if it is another thread unlocks the looper while this one is trying to use it. This patch fixes the problem for me and I detect no regressions but I'd like someone to take a second look. It was discovered while I was attempting to fix #8539 and is (partially) responsible for causing that bug. Can someone with experience with BMenuBar and BHandler/BLooper take a look at my patch and see if there are any problems with it?
Change History (1)
by , 11 years ago
| Attachment: | 0001-Use-LockLooper-in-BMenuBar-_Track-which-is-atomic.patch added |
|---|
Note:
See TracTickets
for help on using tickets.
Patch that replaces window->(Un)Lock() with (Un)LockLooper()