Changes between Initial Version and Version 1 of Ticket #9528, comment 11


Ignore:
Timestamp:
May 20, 2014, 10:41:56 AM (10 years ago)
Author:
ttcoder

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9528, comment 11

    initial v1  
    11Good catch Jerome, one version of _RestoreAttributes() invokes close() whereas the other.. does not. Yet the calling code in Mount() did not compensate for that change. I guess it probably cannot result in a KDL page fault though.. But I'll include the missing `close(fd)` call in whatever patch I submit later (if I'm lucky to get to that stage :-) as leaking file descriptors is probably serious (dunno if there's resource tracking going on when the cdda addon is unloaded)..
     2
     3'''EDIT''': oh, maybe that file descriptor leak explains why an unmounted audio CD is still referred to after being unmounted ? Not sure how that works.