Changes between Version 4 and Version 5 of Ticket #9616, comment 30


Ignore:
Timestamp:
Dec 28, 2014, 9:38:59 PM (10 years ago)
Author:
ttcoder

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9616, comment 30

    v4 v5  
    1313EDIT2: and AC3 + AAC were added in hrev48554, gotta test that!
    1414
    15 EDIT3: a low priority question.. I'm wondering if this [http://cgit.haiku-os.org/haiku/commit/?id=974595bc4673e6e443ae7b6c775cf9461ff2f23d&context=40&ignorews=0&ss=0 change] does not introduce a potential problem: what if `DecodedFormat()`ends up modifying `raf->buffer_size` ? In some scenarios, the `audioBuffer = new uint8[..]`memory allocation higher up might be too small to receive the data that will later be loaded by [http://cgit.haiku-os.org/haiku/tree/src/apps/mediaconverter/MediaConverterApp.cpp?id=5e0e16894d67e220b4684809b154b85db4229381#n583 ReadFrames()], or do I understand that wrong ?
     15EDIT3: a low priority question.. I'm wondering if this [http://cgit.haiku-os.org/haiku/commit/?id=974595bc4673e6e443ae7b6c775cf9461ff2f23d&context=40&ignorews=0&ss=0 change] does not introduce a potential problem: what if the newly added `DecodedFormat()` ends up modifying `raf->buffer_size` ? In some scenarios, the `audioBuffer = new uint8[..]`memory allocation higher up might be too small to receive the data that will later be loaded by [http://cgit.haiku-os.org/haiku/tree/src/apps/mediaconverter/MediaConverterApp.cpp?id=5e0e16894d67e220b4684809b154b85db4229381#n583 ReadFrames()], so the memory/buffer allocation should be moved down below the second DecodedFormat(), or do I understand that wrong ?
    1616