Changes between Initial Version and Version 1 of Ticket #9841, comment 11


Ignore:
Timestamp:
Jun 30, 2013, 2:37:35 PM (8 years ago)
Author:
anevilyak

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9841, comment 11

    initial v1  
    22> There is still fallout from your BTabView change... :-) If you run Terminal, open a second tab, then run "exit" in the second tab, you get an empty Terminal window instead of the contents of the first tab.
    33
    4 Thanks, overlooked that, RemoveTab() was manipulating the index directly instead of letting Select() handle adjusting it, which broke when short circuiting. From the looks of it, no other places in BTabView's code do this, so hopefully that's the last of it. On a loosely related note, I seem to have stumbled across a Terminal bug/race of some form in the process, occasionally Terminal would close the entire window on cmd+w instead of just the active tab. Haven't found a reliable set of steps to reproduce it yet though.
     4Thanks, overlooked that, RemoveTab() was manipulating the index directly instead of letting Select() handle adjusting it, which broke when short circuiting. Fixed in hrev45806. From the looks of it, no other places in BTabView's code do this, so that should be the last of it. On a loosely related note, I seem to have stumbled across a Terminal bug/race of some form in the process: occasionally Terminal would close the entire window on cmd+w instead of just the active tab. Haven't found a reliable set of steps to reproduce it yet though.