Changes between Version 14 and Version 15 of CodingGuidelines/SubmittingPatches


Ignore:
Timestamp:
Jun 27, 2018, 6:18:02 PM (6 years ago)
Author:
humdinger
Comment:

Added info how to update a patch submitted to gerrit

Legend:

Unmodified
Added
Removed
Modified

  • CodingGuidelines/SubmittingPatches

    v14 v15  
    5050After pushing, either '''create a new ticket about this patch''' or '''comment on the ticket your patch fixes''' with a link to the Gerrit review.
    5151
     52=== Updating your commit(s) ===
     53If you need to make changes to your code in the course of a review at Haiku's Gerrit, you make them locally and amend them to your submitted commit:
     54{{{
     55git commit -a --amend
     56}}}
     57Make sure to add "Change-Id: ''here-goes-the-ID-of-your-gerrit-ticket''" '''at the end''' of the commit message. Otherwise you'll create a new gerrit ticket!
     58
     59You submit that update in the same way as you did the original commit:
     60{{{
     61git push origin <local source branch>:refs/for/<remote target branch>
     62}}}
     63
    5264=== Following up ===
    5365''Lastly and most importantly'': once a developer reviews your submitted code, expect them to point out any and all flaws. This is standard procedure and is constructive criticism. Remember, we want to help you improve your coding abilities.