Ticket #2170 (closed enhancement: fixed)

Opened 7 months ago

Last modified 7 months ago

[PATCH] revert button in time preflet + bugfix

Reported by: stpere Owned by: stippi
Priority: normal Milestone: R1
Component: Preferences/Time & Date Version: R1 development
Cc: Blocked By:
Platform: All Blocking:

Description

1. I've added a revert button in Time preflet.
Pressing Revert returns to the date time that was active at the time the preflet started + the uptime of the preflet. The uptime is incremented every time there is a clock tick, I'm pretty sure it's a bad way to do it. Suggestions are welcome -- like if there was a uptime() method or something, that would be perfect ;-)

Changing timezones shouldn't affect the revert functionality.

2. I have also fixed a bug where clicking multiple times on an already selected radio button (local time or gmt) would not toggle it graphically but would still toggle logically (the time changed..) I've fixed that bad behaviour.

Attachments

timepref.diff (5.9 kB) - added by stpere 7 months ago.
Adds a revert button in Time preflets and fix the toggle bug on GMT/localtime radio buttons

Change History

Changed 7 months ago by stpere

Adds a revert button in Time preflets and fix the toggle bug on GMT/localtime radio buttons

Changed 7 months ago by axeld

The uptime should really be computed differently. The easiest way would be to use system_time() which counts the micro seconds since the computer was started - it's not affected by time changes.

Changed 7 months ago by stippi

  • owner changed from axeld to stippi
  • status changed from new to assigned

What Axel said... I am on it! :-)

Changed 7 months ago by stippi

  • status changed from assigned to closed
  • resolution set to fixed

Applied in r25210. Philippe, you could look into the button placement if you want. It could be placed below the tab view instead, and also revert time zone changes.

Note: See TracTickets for help on using tickets.