Opened 14 years ago

Closed 14 years ago

#5312 closed enhancement (fixed)

[PATCH] Boot Loader menu extension

Reported by: Grey Owned by: axeld
Priority: normal Milestone: R1
Component: System/Boot Loader Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #5113
Platform: All

Description

Additional items for Boot Loader menu: "Reboot", "Fast Reboot" (warm boot) and "Shutdown". Patch attached.

Attachments (2)

boot_menu.patch (3.8 KB ) - added by Grey 14 years ago.
boot_menu2.patch (4.8 KB ) - added by Grey 14 years ago.

Download all attachments as: .zip

Change History (11)

by Grey, 14 years ago

Attachment: boot_menu.patch added

comment:1 by axeld, 14 years ago

I don't think "Fast Reboot" deserves its own menu item (instead, I would just activate it via the 'w' key, if the platform supports it). A "Shutdown" facility might be useful, though. What do others think of it?

If you agree to move the fast reboot to a hidden key, and are okay to change that patch, I guess I can close #5113 then? It doesn't cleanly apply anymore, and I think rebooting at that early point is only of limited use, anyway.

in reply to:  1 comment:2 by Grey, 14 years ago

Replying to axeld:

I don't think "Fast Reboot" deserves its own menu item (instead, I would just activate it via the 'w' key, if the platform supports it). A "Shutdown" facility might be useful, though. What do others think of it?

If you agree to move the fast reboot to a hidden key, and are okay to change that patch, I guess I can close #5113 then? It doesn't cleanly apply anymore, and I think rebooting at that early point is only of limited use, anyway.

Okey, I agree. Close #5113, please. Have I change #5312 patch, or you are going to do that youself?

comment:3 by axeld, 14 years ago

I currently don't really have much Haiku time (and I'm sorry that you had to suffer from that). I would appreciate it, if you could extend your patch this way.

comment:4 by axeld, 14 years ago

Blocking: 5113 added

(In #5113) Superceded by #5312.

in reply to:  3 ; comment:5 by Grey, 14 years ago

Replying to axeld:

I currently don't really have much Haiku time (and I'm sorry that you had to suffer from that). I would appreciate it, if you could extend your patch this way.

Ok. New patch attached. Activate "Fast Reboot" via the 'w' key. Help added to "Shutdown" and "Reboot".

by Grey, 14 years ago

Attachment: boot_menu2.patch added

in reply to:  5 comment:6 by Grey, 14 years ago

Replying to Grey:

Replying to axeld:

I currently don't really have much Haiku time (and I'm sorry that you had to suffer from that). I would appreciate it, if you could extend your patch this way.

Ok. New patch attached. Activate "Fast Reboot" via the 'w' key. Help added to "Shutdown" and "Reboot".

Changed 11 days ago by Grey

  • attachment boot_menu2.patch

Is it ok for trunk?

comment:7 by axeld, 14 years ago

Sorry, I haven't had the time to look at it yet. I'll try to do that later today, but I can't promise anything.

comment:8 by axeld, 14 years ago

Status: newin-progress
Version: R1/alpha1R1/Development

Thanks for the new patch. I have now looked into it, and am working to integrate parts of it into trunk.

comment:9 by axeld, 14 years ago

Resolution: fixed
Status: in-progressclosed

I've applied the warm boot stuff in hrev36311, thanks! I introduced a shortcut functionality in the menus that makes a clean solution possible. I don't think that shutdown makes sense in the boot loader, so I left that out.

Thanks!

Note: See TracTickets for help on using tickets.