[Patch] ShowImage app localization

[mt]

Localize GUI strings for ShowImage app. Patch and en.catkeys added.

[mt]

patch file

[stippi]

The patch looks pretty good, thanks a lot!

Just some possible improvements for future patches:

• You could include ControlLook.h and use be_control_look->DefaultItemSpacing() instead of hardcoding 5 or so for layout item spacing. I.e. "float spacing = be_control_look->DefaultItemSpacing();" once and then using "spacing" everywhere.
• The bs_printf() function has some tabs or weird spacing between type and variable names.
• The coding cleanups are greatly appreciated. In some places you could also improve variable names to be slightly more descriptive, but it would certainly not prevent me from applying this patch.

Thanks for the good work you are doing, mt. IMHO you should be proposed for commit access soon. :-)

[mt]

I applied be_control_look->DefaultItemSpacing() and modified bs_printf(). please review.

[mt]

Second patch

[stippi]

Thanks a bunch! Applied in hrev35929. Don't know what to do with en.catkeys. Isn't that file auto-generated?

[mt]

Replying to stippi:

Thanks a bunch! Applied in hrev35929. Don't know what to do with en.catkeys. Isn't that file auto-generated?

Thanks for applying patch. I added en.catkeys on this ticket for reference, so it does not need to apply to Haiku tree.

[Karvjorm]

Another localization update for ShowImage app.

[Karvjorm]

I found some strings not yet localized in ShowImage app. I compiled ShowImageUpdate.patch to fix these. This is my first patch, so I do not know, if I compiled it correct.

[stippi]

The patch is the right direction in principle, but the string composition needs to be changed. One sentence with a variable in it should be translatable as one sentence, so other translations can put the variable at any place. I know this is still possible if the sentence is composed of just three parts, but it's not good style to keep it like that. It can be changed for example by using a stack allocated buffer and using snprintf().

[stippi]

Fixed the issues myself and applied the patch in hrev36647, thanks!