Deskbar menu closes when mouse cursor is over separator

[idefix]

Tested with hrev46187.

Steps to reproduce:

• Click on the Deskbar leaf and keep the mouse button down
• Move the mouse pointer over a separator in the Deskbar menu.
• The menu closes

The menu should stay open.

If the mouse button is up when the mouse pointer moves over a separator, the menu stays open.

The menu's in Webpositive also exhibit this behaviour.

The right-click menu on the desktop doesn't exhibit this behaviour.

[ttcoder]

irritating recent little regression in the BMenu tracking code indeed... post 46xxx as I recall. I gotta use the "click to open" behavior in order to use the deskbar (and other menus) now.. I'd much rather keep the mouse button held down all along, faster that way..

[anevilyak]

The only likely candidate in relatively recent time would be hrev45988. Please verify if possible.

[jscipione]

Menu code is tricky, hrev45977 is more likely the cause. My guess for a fix is to include separator items in BMenu::_HitTestItems() again and then skip the separators on a case-by-case basis so as to prevent the crash described in #4417 while being careful not to regress the bug described by #6610.

[jscipione]

Fixed in hrev46191 by reverting hrev45988

Thanks for reporting.