[package_daemon] Can't reactivate a package if it was removed while the daemon was not running

[diver]

package_daemon can't reactivate a package if it wasn't running (e.g. it crashed) when the package was moved out of packages folder.

pkgman install --home bepdf
hey package_daemon quit
mv ~/config/packages/bepdf-1.1.1~beta5_2013_04_28-1-x86_gcc2.hpkg .
/system/servers/package_daemon &
mv bepdf-1.1.1~beta5_2013_04_28-1-x86_gcc2.hpkg ~/config/packages/

syslog snippet:

package_daemon [6639204657:   704] Volume::_PackagesEntryCreated("bepdf-1.1.1~beta5_2013_04_28-1-x86_gcc2.hpkg")
package_daemon [6639583920:   704] Volume::_ChangePackageActivation(): activating 1, deactivating 0 packages
packagefs [6639584083:   704] Volume::_ChangeActivation(): package to activate already activated: "bepdf-1.1.1~beta5_2013_04_28-1-x86_gcc2.hpkg"

[waddlesplash]

Still an issue?

[leavengood]

I am sure this is still an issue. I am trying to decide if it is valid. It is a lot to ask to kill the package_daemon and then be surprised it missed something.

But this may not be too hard to fix. I am sure on start the daemon is just loading the activated-packages file and using that as a canonical source. A quick fix would be to remove any packages from that list which are not actually in the packages directories at load time.