Opened 11 years ago

Closed 11 years ago

#10226 closed bug (fixed)

Fixed resource leak and possible strings without null-termiator

Reported by: Ezodev Owned by: bonefish
Priority: normal Milestone: R1
Component: System/Kernel Version: R1/Development
Keywords: gci2013 Cc:
Blocked By: Blocking:
Platform: All

Description

Found in coverity, CIDs: 605891, 990975

Attachments (2)

0001-Fixed-resource-leak-and-possible-strings-without-nul.patch​ (2.0 KB ) - added by Ezodev 11 years ago.
0001-Fixed-resource-leak-and-possible-strings-corruption.patch​ (1.4 KB ) - added by Ezodev 11 years ago.

Download all attachments as: .zip

Change History (6)

by Ezodev, 11 years ago

Attachment: 0001-Fixed-resource-leak-and-possible-strings-without-nul.patch​ added

comment:1 by Ezodev, 11 years ago

patch: 0 → 1

comment:2 by anevilyak, 11 years ago

Component: - General → System/Kernel
Owner: changed from nobody to bonefish
Status: new → assigned

The resource leak could be fixed more simply by just moving the first call to unload_driver_settings() down two lines (just before the closing curly brace for if (settings != NULL)). That would render both the boolean flag and consequent additional calls to unload_driver_settings() entirely unnecessary.

by Ezodev, 11 years ago

Attachment: 0001-Fixed-resource-leak-and-possible-strings-corruption.patch​ added

comment:3 by Ezodev, 11 years ago

done, I hasn't checked that settings were not used after this if.

comment:4 by bonefish, 11 years ago

Resolution: → fixed
Status: assigned → closed

Thanks, applied in hrev46410.

Note: See TracTickets for help on using tickets.