Opened 5 years ago

Closed 5 years ago

#10226 closed bug (fixed)

Fixed resource leak and possible strings without null-termiator

Reported by: Ezodev Owned by: bonefish
Priority: normal Milestone: R1
Component: System/Kernel Version: R1/Development
Keywords: gci2013 Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Found in coverity, CIDs: 605891, 990975

Attachments (2)

Change History (6)

comment:1 Changed 5 years ago by Ezodev

Has a Patch: set

comment:2 Changed 5 years ago by anevilyak

Component: - GeneralSystem/Kernel
Owner: changed from nobody to bonefish
Status: newassigned

The resource leak could be fixed more simply by just moving the first call to unload_driver_settings() down two lines (just before the closing curly brace for if (settings != NULL)). That would render both the boolean flag and consequent additional calls to unload_driver_settings() entirely unnecessary.

comment:3 Changed 5 years ago by Ezodev

done, I hasn't checked that settings were not used after this if.

comment:4 Changed 5 years ago by bonefish

Resolution: fixed
Status: assignedclosed

Thanks, applied in hrev46410.

Note: See TracTickets for help on using tickets.