8-bit icons in Tracker's context menu's "New" submenu

[jonas.kirilla]

Tracker's context menu's "New" menu items still show 8-bit icons, so here's a patch for review and commit:

​http://www.kirilla.com/haiku/IconMenuItem.cpp.diff

I don't know if the Push/PopState() is necessary.

[jonas.kirilla]

Possible fix

[axeld]

Thanks for the patch! Bug reports like this are the best :-) Unfortunately, I can't commit it, as it will break Tracker's "New" menu on R5. If you have the time to rework it for both builds, I'd appreciate it, but if not, I can do it as well. Just tell me.

The Push/PopState() should not be necessary (at least not if it wasn't before), but it shouldn't hurt either.

[jonas.kirilla]

Replying to axeld:

If you have the time to rework it for both builds, I'd appreciate it, but if not, I can do it as well. Just tell me.

I can do it tomorrow or early next week. I suppose with ifdefs for Haiku/BeOS in the IconMenuItems' constructors bitmap creation (CMAP8/RGB32) and for part of DrawContent().

[axeld]

That should pretty much be it, yes :-) Thanks!

[jonas.kirilla]

I think I'm done. See attachment: IconMenuItem.cpp.2.diff

Axel, feel free to edit as you see fit. I'll take a look at your changes in SVN.

[jonas.kirilla]

Having had another look at the result, magnified, I think the line "where.y = Frame().top + 2;" should be "where.y = Frame().top + 1;" instead, so there's space below as well as above the icon.

[axeld]

Thanks! Patch applied in hrev20240. While I was at it, I've changed the positioning code to duplicate the method used in ModelMenuItem which should work better with larger font sizes.