Opened 10 years ago

Closed 9 years ago

#10369 closed bug (invalid)

Fix Coverity CID 991754: unused pointer value

Reported by: noryb009 Owned by: nobody
Priority: low Milestone: R1
Component: Drivers/Network Version: R1/Development
Keywords: gci2013 Cc:
Blocked By: Blocking:
Platform: All

Description

For GCI2013 task: ​http://www.google-melange.com/gci/task/view/google/gci2013/5289390804828160

Attachments (1)

0001-Coverity-CID-991754-fix-unused-pointer-value.patch​ (1001 bytes ) - added by noryb009 10 years ago.

Download all attachments as: .zip

Change History (9)

by noryb009, 10 years ago

Attachment: 0001-Coverity-CID-991754-fix-unused-pointer-value.patch​ added

comment:1 by noryb009, 10 years ago

patch: 0 → 1

comment:2 by umccullough, 10 years ago

Technically, this is borrowed FreeBSD code - so the issue is really upstream. We could, however, send the patch upstream I suppose.

comment:3 by noryb009, 10 years ago

Would you like me to do so?

comment:4 by umccullough, 10 years ago

Sure!

I don't have any clue what the process of upstreaming fixes to FreeBSD is, unfortunately.

Also, they do use Coverity Scan as well - so it's likely they have their own report of this issue lurking in there somewhere.

comment:5 by noryb009, 10 years ago

It looks like the function has had a few changes upstream, including the equivalent of the patch: ​http://svnweb.freebsd.org/base/head/sys/dev/vge/if_vge.c?view=markup#l2022

Last edited 10 years ago by noryb009 (previous) (diff)

comment:6 by umccullough, 10 years ago

Priority: normal → low

This fix probably should be obtained from upstream then.

comment:7 by umccullough, 10 years ago

patch: 1 → 0

comment:8 by waddlesplash, 9 years ago

Resolution: → invalid
Status: new → closed

A couple people are poking at a FreeBSD drivers upgrade; no need to let this sit around until they do so just to get forgotten...

Note: See TracTickets for help on using tickets.