WebPositive: Javascript console

[pulkomandy]

JS console message currently go to stdout. This isn't very practical.

Add a window to show it from the UI instead.

[dsjonny]

+1 And it would be also fine if in that window we can see any HTML/CSS alert too like in Firefox.

[zhuowei]

I made a very simple console window that shows all the console messages in a list. The window can be opened with Window -> Script console. The patch is attached above. (gsoc2014)

[pulkomandy]

There is at least one problem with this:

• Open the script console
• Close it
• Try to open it again

When closing a window, the C++ object is automatically deleted. So, opening it again won't work. You can see the code in SettingsWindow::QuitRequested() to avoid this problem: the window is hidden, instead of destroyed.

I think the window could also be further improved:

• A "clear" button would be useful
• The list view could have a 5 pixel margin between it and the window border
• The horizontal scrollbar should be disabled if there is no need for it

[zhuowei]

I've added a clear button, a 5px border, and overrode QuitRequested to hide the window instead. Sorry about the delay.

I couldn't figure out how to disable the horizontal scrollbar, nor was I able to get the ListView to scroll down to the latest item when added. (for the autoscroll, I tried running ScrollBy(0, 1000) every time a message is added, but this caused repeated drawing, which froze the browser.)

[pulkomandy]

You now have some style violations:

• One line is over 80 columns in ConsoleWindow.cpp
• Always two blank lines between top-level blocks: two methods definitions, includes and forward declarations, forward declarations and class definition, etc. (you have only one most of the time, and up to 3)
• The members of ConsoleWindow class should be indented like the method declarations (in the .h file)
• ConsoleWindow.h is missing a forward declaration of BButton
• "final" is a keyword in C++11, and you use it as a variable name in ConsoleWindow::MessageReceived()

​https://www.haiku-os.org/development/coding-guidelines

[zhuowei]

Adds a simple console window

[pulkomandy]

Applied in hrev47037. Thanks!