Opened 4 years ago

Last modified 3 months ago

#10573 assigned enhancement

Implement BFont::IsFullAndHalfFixed

Reported by: jackburton Owned by: Nobody
Priority: normal Milestone: R1
Component: Servers/app_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #13810
Has a Patch: no Platform: All


The server side support for BFont::IsFullAndHalfFixed() is missing.

Attachments (1)

0001-Server-side-support-for-BFont-IsFullAndHalfFixed.patch (2.4 KB) - added by jackburton 4 years ago.
Tentative patch

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by jackburton

Tentative patch

comment:1 Changed 4 years ago by jackburton

The patch implements the server side part of BFont::IsFullAndHalfFixed(), although it has some race condition, since at every other boot, the app_server hangs. What am I doing wrong ?

comment:2 Changed 4 years ago by jackburton

Has a Patch: set

comment:3 Changed 4 years ago by Rene Gollent

Component: - GeneralServers/app_server
Owner: changed from Nobody to axeld
Type: bugenhancement

comment:4 Changed 4 years ago by korli

What about FontStyle::UpdateFace()?

comment:5 Changed 4 years ago by Stephan Aßmus

From the patch, it doesn't seem like it should be able to hang app_server. Maybe there already is a race-condition in the code, and since the constructor now runs longer for each font that is not fixed width, the existing race condition is triggered more often.

comment:6 in reply to:  4 Changed 4 years ago by jackburton

Replying to korli:

What about FontStyle::UpdateFace()?

I guess it should be done there, too (or, only there).

comment:7 Changed 13 months ago by axeld

Owner: changed from axeld to Nobody
Status: newassigned

comment:8 Changed 5 months ago by waddlesplash

Blocking: 13810 added

comment:9 Changed 3 months ago by PulkoMandy

Patch migrated to Gerrit:

comment:10 Changed 3 months ago by PulkoMandy

Has a Patch: unset
Note: See TracTickets for help on using tickets.