Opened 6 years ago

Closed 13 months ago

#10573 closed enhancement (fixed)

Implement BFont::IsFullAndHalfFixed

Reported by: jackburton Owned by: nobody
Priority: normal Milestone: R1
Component: Servers/app_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #13810
Has a Patch: no Platform: All

Description

The server side support for BFont::IsFullAndHalfFixed() is missing.

Attachments (1)

0001-Server-side-support-for-BFont-IsFullAndHalfFixed.patch (2.4 KB ) - added by jackburton 6 years ago.
Tentative patch

Download all attachments as: .zip

Change History (12)

by jackburton, 6 years ago

Tentative patch

comment:1 by jackburton, 6 years ago

The patch implements the server side part of BFont::IsFullAndHalfFixed(), although it has some race condition, since at every other boot, the app_server hangs. What am I doing wrong ?

comment:2 by jackburton, 6 years ago

Has a Patch: set

comment:3 by anevilyak, 6 years ago

Component: - GeneralServers/app_server
Owner: changed from nobody to axeld
Type: bugenhancement

comment:4 by korli, 6 years ago

What about FontStyle::UpdateFace()?

comment:5 by stippi, 6 years ago

From the patch, it doesn't seem like it should be able to hang app_server. Maybe there already is a race-condition in the code, and since the constructor now runs longer for each font that is not fixed width, the existing race condition is triggered more often.

in reply to:  4 comment:6 by jackburton, 6 years ago

Replying to korli:

What about FontStyle::UpdateFace()?

I guess it should be done there, too (or, only there).

comment:7 by axeld, 3 years ago

Owner: changed from axeld to nobody
Status: newassigned

comment:8 by waddlesplash, 2 years ago

Blocking: 13810 added

comment:9 by pulkomandy, 22 months ago

Patch migrated to Gerrit: https://review.haiku-os.org/47

comment:10 by pulkomandy, 22 months ago

Has a Patch: unset

comment:11 by waddlesplash, 13 months ago

Resolution: fixed
Status: assignedclosed

Patch was merged.

Note: See TracTickets for help on using tickets.