Opened 2 months ago

Last modified 2 months ago

#10573 new enhancement

Implement BFont::IsFullAndHalfFixed

Reported by: jackburton Owned by: axeld
Priority: normal Milestone: R1
Component: Servers/app_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

The server side support for BFont::IsFullAndHalfFixed() is missing.

Attachments (1)

0001-Server-side-support-for-BFont-IsFullAndHalfFixed.patch (2.4 KB) - added by jackburton 2 months ago.
Tentative patch

Download all attachments as: .zip

Change History (7)

Changed 2 months ago by jackburton

Tentative patch

comment:1 Changed 2 months ago by jackburton

The patch implements the server side part of BFont::IsFullAndHalfFixed(), although it has some race condition, since at every other boot, the app_server hangs. What am I doing wrong ?

comment:2 Changed 2 months ago by jackburton

  • Has a Patch set

comment:3 Changed 2 months ago by anevilyak

  • Component changed from - General to Servers/app_server
  • Owner changed from nobody to axeld
  • Type changed from bug to enhancement

comment:4 follow-up: Changed 2 months ago by korli

What about FontStyle::UpdateFace()?

comment:5 Changed 2 months ago by stippi

From the patch, it doesn't seem like it should be able to hang app_server. Maybe there already is a race-condition in the code, and since the constructor now runs longer for each font that is not fixed width, the existing race condition is triggered more often.

comment:6 in reply to: ↑ 4 Changed 2 months ago by jackburton

Replying to korli:

What about FontStyle::UpdateFace()?

I guess it should be done there, too (or, only there).

Note: See TracTickets for help on using tickets.